Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: dirvish#add_icon_fn break help file highlighting #253

Closed
brianhuster opened this issue Jan 23, 2025 · 0 comments · Fixed by brianhuster/vim-dirvish#1
Closed

Bug: dirvish#add_icon_fn break help file highlighting #253

brianhuster opened this issue Jan 23, 2025 · 0 comments · Fixed by brianhuster/vim-dirvish#1

Comments

@brianhuster
Copy link
Contributor

brianhuster commented Jan 23, 2025 •
edited
Loading

I find it hard to explain, so I will go straight to reproducing

  1. git clone --depth=1 https://github.com/justinmk/vim-dirvish
  2. Create a file repro.vim in current directory and add the following
set rtp+=./vim-dirvish
helptags ALL
call dirvish#add_icon_fn({p -> p[-1:] == '/' ? '📂' : '📄'})
runtime! plugin/dirvish.vim
  1. Open Nvim with nvim -u repro.vim
  2. Open Dirvish with :Dirvish
  3. Open any help doc. Eg. :h dirvish
  4. You will see something similar to what I see

Image

Neovim version

NVIM v0.11.0-dev-1589+g71507281fb                                                                                                                                          
Build type: RelWithDebInfo                                                                                                                                                 
LuaJIT 2.1.1736781742
@brianhuster brianhuster changed the title Bug: vim-dirvish break help file highlighting Bug: dirvish#add_icon_fn break help file highlighting Jan 23, 2025
brianhuster added a commit to brianhuster/vim-dirvish that referenced this issue Feb 6, 2025
@brianhuster
feat(icons): use virtual text if possible (has('nvim') or has('textpr…
4a84bd6 
…op'))

Closes justinmk#145, justinmk#253
brianhuster added a commit to brianhuster/vim-dirvish that referenced this issue Feb 6, 2025
@brianhuster
feat(icons): use virtual text if possible (has('nvim') or has('textpr…
133b9cd 
…op'))

Closes justinmk#145, justinmk#253
@brianhuster brianhuster mentioned this issue Feb 6, 2025
Merged
brianhuster added a commit to brianhuster/vim-dirvish that referenced this issue Feb 6, 2025
@brianhuster
feat(icons): use virtual text if possible (has('nvim') or has('textpr…
fc6b544 
…op'))

Closes justinmk#145, justinmk#253
brianhuster added a commit to brianhuster/vim-dirvish that referenced this issue Feb 6, 2025
@brianhuster
feat(icons): use virtual text if possible (has('nvim') or has('textpr…
b9f240c 
…op'))

Closes justinmk#145, justinmk#253
brianhuster added a commit to brianhuster/vim-dirvish that referenced this issue Feb 6, 2025
@brianhuster
feat(icons): use virtual text if possible (has('nvim') or has('textpr…
51fdab3 
…op'))

Closes justinmk#145, justinmk#253
@brianhuster brianhuster mentioned this issue Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(icons): use virtual text if possible #255 justinmk/vim-dirvish
1 participant
@brianhuster