Skip to content

Rfc draft #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Rfc draft #1

wants to merge 3 commits into from

Conversation

jzeiders
Copy link
Owner

No description provided.

SteveL-MSFT
SteveL-MSFT suggested changes Jun 18, 2019
View reviewed changes
Copy link

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely include a screenshot

SteveL-MSFT
SteveL-MSFT suggested changes Jun 20, 2019
View reviewed changes
Copy link

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can add the screenshot (there's an assets folder in this repo you can put the image, just create a subfolder specific to this RFC to keep it organized) and address my last comment, it's probably good enough for public consumption.

SteveL-MSFT
SteveL-MSFT approved these changes Jun 20, 2019
View reviewed changes
Copy link

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joeyaiello
joeyaiello approved these changes Jun 20, 2019
View reviewed changes
Copy link

@joeyaiello joeyaiello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just fixed a couple minor typos and changed some formatting that improves readability a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyaiello joeyaiello joeyaiello approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzeiders @joeyaiello @SteveL-MSFT