Skip to content

BE: SR: Fix HTTP 400 with slashes in schema name #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Conversation

Haarolean
Copy link
Member

@Haarolean Haarolean commented Feb 19, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Some questionable decisions on spring's side resulted in us unable to receive HTTP requests with encoded forward slash
spring-projects/spring-security@0e257b5#diff-497e4c636b38384ac7f55614db8d7613dfbd02b77b0287c1954f9e7fc42e72c0R64-R67
spring-projects/spring-security#15967
Resolves #848

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean self-assigned this Feb 19, 2025
@Haarolean Haarolean requested a review from a team as a code owner February 19, 2025 15:41
@kapybro kapybro bot added status/triage Issues pending maintainers triage area/sr Schema Registry status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 19, 2025
@Haarolean Haarolean added scope/backend Related to backend changes type/bug Something isn't working labels Feb 19, 2025
@Haarolean Haarolean added this to the 1.1.1 milestone Feb 19, 2025
@Haarolean Haarolean enabled auto-merge (squash) February 19, 2025 15:44
@Haarolean Haarolean merged commit 07b5904 into main Feb 24, 2025
15 of 16 checks passed
@Haarolean Haarolean deleted the issues/848 branch February 24, 2025 20:00
@Haarolean Haarolean modified the milestones: 1.1.1, 1.2 Mar 15, 2025
@Haarolean Haarolean moved this from Todo to Done in Release 1.2 Mar 15, 2025
git-halinka pushed a commit to sainsburys-tech/kafka-ui that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sr Schema Registry scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SR: HTTP 400 when name contains forward slash
2 participants