Skip to content

📖 update documentation #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2025
Merged

📖 update documentation #14

merged 2 commits into from
Jan 30, 2025

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jan 30, 2025

Summary

This removes the old Helm-based RBAC setup and explains how to do it nowadays. Plus it adds an FAQ section to the docs.

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jan 30, 2025
@xrstf xrstf requested a review from embik January 30, 2025 14:51
@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 30, 2025
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but please also update the helm install section in getting-started.md. It's using an OCI reference, which won't work. Let's document adding the Helm repo and installing the latest version from it automatically (i.e. don't pass a version flag).

Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 68b4971b00b7693e4c6f97fbce9d2bd49b402f0d

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2025
@kcp-ci-bot kcp-ci-bot merged commit 9edf625 into main Jan 30, 2025
9 of 10 checks passed
@kcp-ci-bot kcp-ci-bot deleted the update-docs branch January 30, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants