You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# Details
Problem outlined in: #62
Link header is added to `toc` table, however this happens after the
ToC is rendered so it is effectively ignored.
Change rendering order so links are added before the ToC.
Updated a unit test case to catch this.
Hi, thanks for creating this awesome script to automate document generation!
When I run this script I notice that it adds a Links heading but does not add this to the ToC section.
This happens in the example for this repo as well: https://github.com/kdheepak/panvimdoc/blob/main/doc/panvimdoc.txt
Where there is a heading at the bottom "13. Links", but its not in the ToC at the top.
Based on this line: https://github.com/kdheepak/panvimdoc/blob/main/scripts/panvimdoc.lua#L173, this does not seem intentional.
I believe this happens because of the order the Writer calls methods in: https://github.com/kdheepak/panvimdoc/blob/main/scripts/panvimdoc.lua#L202C1-L206C32
Here the toc gets generated before the notes and as a result appending to the
toc
table inrenderToc
has no effect.I believe the fix for this is just to re-order these calls so that
renderNotes
is called beforerenderToc
:The text was updated successfully, but these errors were encountered: