Skip to content

Loading YAML configs works only for files found in top-level config_path #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pawiecz opened this issue Apr 25, 2025 · 0 comments · May be fixed by #2860
Open

Loading YAML configs works only for files found in top-level config_path #2859

pawiecz opened this issue Apr 25, 2025 · 0 comments · May be fixed by #2860

Comments

@pawiecz
Copy link
Contributor

pawiecz commented Apr 25, 2025

Docstring for function iterate_yaml_files() states that it should traverse over given directory and "find multiple YAML files recursively".

Pull request kernelci/kernelci-pipeline#1132 shows that this statement is false - PR introduces additional level of directories (trees/) which are ignored by said function:

In [1]: glob.glob(os.path.join('config', '*.yaml'))
Out[1]: 
['config/trees.yaml',
 'config/scheduler.yaml',
 'config/pipeline.yaml',
 'config/platforms.yaml',
 'config/scheduler-chromeos.yaml',
 'config/jobs-chromeos.yaml',
 'config/result-summary.yaml',
 'config/jobs.yaml',
 'config/traces_config.yaml',
 'config/platforms-chromeos.yaml']
# 'config/trees/linux-pci.yaml' is missing
pawiecz added a commit to pawiecz/kernelci-core that referenced this issue Apr 25, 2025
@pawiecz
config: Find YAML files recursively
cfd76a6 
Previously only top-level files were found in a given directory.

Fixes: kernelci#2859

Signed-off-by: Paweł Wieczorek <[email protected]>
pawiecz added a commit to pawiecz/kernelci-core that referenced this issue Apr 25, 2025
@pawiecz
config: Find YAML files recursively
4aab0ae 
Previously only top-level files were found in a given directory.

Fixes: kernelci#2859

Signed-off-by: Paweł Wieczorek <[email protected]>
@pawiecz pawiecz linked a pull request Apr 25, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: Find YAML files recursively pawiecz/kernelci-core
1 participant
@pawiecz