Ensure content-type properly reflects gateway kernelspec resources #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mehmet Bektas <[email protected]>
kevin-bates
force-pushed
the
gateway-resource-content-type
branch
from
89da3a3 to
6747756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
APIHandler.finish()method unconditionally overrides the header'sContent-typetoapplication/jsondespite theGatewayResourceHandlersetting it to a mime-type corresponding to the resource's extension.This pull request enables the caller to indicate the
ContentTypethat should be set into the header inAPIHandler.finish()whereapplication/jsonis the default if no content type is specified.