Fix for bash script kvm-qemu.sh when installing libvmi

[minaton-ru]

Hello everyone!
Please review a small fix to the file installer/kvm-qemu.sh for the libvmi installation script.

When installing KVM/QEMU twice using this script I received such the error every time:

bash: cd: libvmi-v0.14.0: No such file or directory

How to reproduce

cd /tmp
wget -q https://github.com/libvmi/libvmi/archive/refs/tags/v0.14.0.zip -O libvmi-v0.14.0.zip
unzip libvmi-v0.14.0.zip
cd "libvmi-v0.14.0"

Expected result

user@ubuntu24:/tmp/libvmi-v0.14.0$

The actual result

bash: cd: libvmi-v0.14.0: No such file or directory

Description

The downloaded file libvmi-v0.14.0.zip has the libvmi-0.14.0 directory inside, not the libvmi-v0.14.0.

What to be changed

This string:

cd "libvmi-v0.14.0" || return

is changing to this:

cd "libvmi-0.14.0" || return

[gemini-code-assist]

Hello @minaton-ru, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses an issue in the installer/kvm-qemu.sh script where the script fails when trying to install KVM/QEMU twice. The problem is due to an incorrect directory name used in the cd command after unzipping the libvmi archive. The script attempts to change the directory to libvmi-v0.14.0, but the actual directory created after unzipping is libvmi-0.14.0. This PR corrects the directory name in the cd command, resolving the issue.

Highlights

• Bug Fix: Corrects the directory name in the cd command within the installer/kvm-qemu.sh script to match the actual directory created after unzipping the libvmi archive.
• Installation Script: Addresses an issue that prevents the KVM/QEMU installation script from running successfully when installing libvmi more than once.

Changelog

• installer/kvm-qemu.sh
  • Corrected the directory name in the cd command from libvmi-v0.14.0 to libvmi-0.14.0 on line 297.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A script's lament,
A directory misnamed,
Fix brings sweet relief.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request addresses an issue where the installation script fails when KVM/QEMU is installed multiple times due to an incorrect directory name. The provided fix updates the directory name in the cd command, resolving the issue. The change is straightforward and effective.

Merge Readiness

The code change appears to be correct and addresses the reported issue. I recommend merging this pull request after verifying that the change resolves the problem as described. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

[doomedraven]

thank you