Skip to content

Revert "Enable serial autoflush" #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Revert "Enable serial autoflush" #3

merged 1 commit into from
Jul 6, 2022

Conversation

algernon
Copy link

@algernon algernon commented Jul 6, 2022

This reverts commit 74d9e51, because it caused a whole lot of issues, including leading up to complete lockups under certain common scenarios.

The revert fixes keyboardio/Chrysalis#985.

This reverts commit 74d9e51, because
it caused a whole lot of issues, including leading up to complete
lockups under certain common scenarios.

The revert fixes keyboardio/Chrysalis#985.

Signed-off-by: Gergely Nagy <[email protected]>
@algernon algernon added the bug Something isn't working label Jul 6, 2022
@algernon algernon requested a review from obra July 6, 2022 23:01
@obra
Copy link
Member

obra commented Jul 6, 2022 via email

@algernon
Copy link
Author

algernon commented Jul 6, 2022

Lucky for us, the kind of manual flushing we already do.

@obra obra merged commit 3de303a into main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Serial communication is sometimes flaky
2 participants