Upgrade codebase #11
Merged
Upgrade codebase #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use native fetch to make API request.
Install xss to sanitize untrusted HTML
Use async thunk actions and action creators.
Use async thunk actions and action creators.
Import the correct component
Use async thunk actions and action creators. Use createAction for logout action.
Use async thunk actions and action creators. TODO: handle getByAuthor async thunk action
Install @testing-library/cypress and @cypress/code-coverage
Check when is unathenticated. Check the structure of the page.
Check when is unathenticated. Navigate trought all the app.
Validate the form. Install faker to generate test data.
Validate the form. Add test user in Cypress' env.
Allow to Cypress to access the Redux Store. Validate the form. Create a new article. Add custom command to dispatch actions to the store. Add custom command to login.
Edit an article. Add custom command to create a new article using the API.
Create a new comment Delete a comment Remove an article TODO: fix add new comment at the beginning of the list TODO: fix show validation errors
Navigate to edit the article. Do not download a random markdown.
Follow/unfollow a user. Add a task to generate an user and an article. TODO(backend): fix get articles by author for a different user than authenticated user.
Check when is authenticated.
Check when is authenticated. Mark an article as favorite/unfavorite.
# Conflicts: # package-lock.json # package.json
Add new comment at the beginning. Show validation errors. Remove a comment.
Add new comment at the beginning. Show validation errors.
Document all components. Prefer use hooks over prop drilling. BREAKING CHANGE lazy load the CommentContainer, handle the case when article is loading or not exists
Use hooks over props. Document all components.
Document all components. Prefer use hooks over prop drilling. Do not override tags when fetch articles by tag. BREAKING CHANGE tags are fetched from tag component not home component
Document all components.
Help to recreate the store inside the tests.
Add custom render function, wrap the providers.
Move all authentication state to it. BREAKING CHANGE removed loginPageUnloaded and registerPageUnloaded
Unit test the reducer and selectors
Both Login and Register share almost all the UI, so, to reduce duplicate code. BREAKING CHANGE: remove Login and Register components and use only one screen
Now these features are under auth slice. BREAKING CHANGE: remove settingsPageUnloaded
Move to `auth` folder.
Add a slice to manage the comments.
…rade react-router v6
✅ Deploy Preview for react-redux-realworld ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges in #5