Skip to content

adding re-ranking #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 18, 2025
Merged

adding re-ranking #96

merged 14 commits into from
Mar 18, 2025

Conversation

vaiju1981
Copy link
Contributor

@vaiju1981 vaiju1981 commented Mar 12, 2025

  1. Ability to call rerank method - done
  2. Sorting the results based on the score - done
  3. Adding test suites - Done

@vaiju1981 vaiju1981 mentioned this pull request Mar 13, 2025
@vaiju1981
Copy link
Contributor Author

@kherud this is ready for review.

@kherud
Copy link
Owner

kherud commented Mar 18, 2025

Hey @vaiju1981 thank you again for another awesome PR! It looks great, I made a few small changes and other additions from issues/requests that came up the last days, I hope that's ok:

  • The biggest change was probably to remove jackson, and simply use a string builder instead. Jackson is quite a heavy dependency and we should try to keep dependencies as simple as possible.
  • I updated to the newest llama.cpp version.

If everything goes well now, I'll merge it and release a new version.

@kherud kherud merged commit 5c34026 into kherud:master Mar 18, 2025
4 checks passed
@vaiju1981
Copy link
Contributor Author

@kherud sounds great. Your changes look good.

@kherud
Copy link
Owner

kherud commented Mar 18, 2025

Version 4.1.0 is published 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants