Skip to content

Update ffmpeg/ffpyplayer versions #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Update ffmpeg/ffpyplayer versions #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df7395f
Update ffmpeg/ffpyplayer versions
tito Jun 10, 2022
cadd2fe
Add missing sdl2 dependency
AndreMiras Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kivy_ios/recipes/ffmpeg/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@


class FFMpegRecipe(Recipe):
version = "n4.3.1"
version = "n4.4.2"
url = "https://github.com/FFmpeg/FFmpeg/archive/{version}.zip"
include_per_arch = True
include_dir = "dist/include"
Expand Down
4 changes: 2 additions & 2 deletions kivy_ios/recipes/ffpyplayer/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@


class FFPyplayerRecipe(CythonRecipe):
version = "4.2.0"
version = "v4.3.5"
url = "https://github.com/matham/ffpyplayer/archive/{version}.zip"
Comment on lines +6 to 7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly overlooked that change, but don't we usually exclude the v from the version so the package pinning won't have to include it?
So I mean url could be:

url = "https://github.com/matham/ffpyplayer/archive/v{version}.zip"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes/no ? Otherwise there is no way to go back to a specific archive if not pinned with a v ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 That's a good question.

Pros:

  • Users will likely try to pin versions like ffpyplayer==4.x.x, as they are used to doing the same when installing things via pip (and etc).

Cons:

  • We can't pin a specific hash or tag (if that tag is not prepended by v) without changing the URL

Some personal considerations about it + one extra question:

  • Recipes are not expected to work fine between multiple versions of the same package (or at least are not tested), so pinning a specific version of a package that needs a recipe to install should be discouraged IMHO.
  • Maybe ffpyplayer is not the case, but sometimes we need to target a specific tag or hash as a temp workaround (that happened in past with SDL2 and Kivy).
  • Maybe we should print a WARNING regarding potential unexpected issues while pinning a specific version on a recipe?

BTW, I'm +1 for keeping the v into the version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good point thanks guys, I leave that to you, I'm fine either ways 👍

library = "libffpyplayer.a"
depends = ["python", "ffmpeg"]
depends = ["python", "sdl2", "ffmpeg"]
pbx_frameworks = [
"CoreVideo", "CoreMedia", "CoreImage", "AVFoundation", "UIKit",
"CoreMotion"]
Expand Down