Skip to content

Fix setup.py install breaking due to unicode characters in README.md on Python 3 #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Feb 3, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2019

Fix setup.py install breaking due to unicode characters in README.md on Python 3

@AndreMiras
Copy link
Member

Thanks for giving it a try!
But I think the fix actually is #1666 right?
Have you tried running tox on your changes locally?

@ghost
Copy link
Author

ghost commented Feb 3, 2019

@AndreMiras the fix for what? This fixes setup.py blowing up if unicode characters are in README.md, which they are right now

@ghost ghost changed the title [WIP] Fix setup.py install breaking due to encoding errors in README.md on Python 3 [WIP] Fix setup.py install breaking due to unicode characters in README.md on Python 3 Feb 3, 2019
@ghost ghost changed the title [WIP] Fix setup.py install breaking due to unicode characters in README.md on Python 3 Fix setup.py install breaking due to unicode characters in README.md on Python 3 Feb 3, 2019
@ghost
Copy link
Author

ghost commented Feb 3, 2019

Ok, fix works for me (tested both Python 3 and Python 2 install). Since I forgot to post the backtrace and this came up in chat, this is what it fixes:

Collecting https://github.com/kivy/python-for-android/archive/master.zip
  Downloading https://github.com/kivy/python-for-android/archive/master.zip
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-gpvwn6h5/setup.py", line 56, in <module>
        long_description = fileh.read()
      File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xf0 in position 5032: ordinal not in range(128)

@AndreMiras
Copy link
Member

Thanks for clarifying and thanks for simplifying the initial PR

Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@inclement inclement merged commit dec1bad into kivy:master Feb 3, 2019
@ghost ghost deleted the setup_py_fix branch April 7, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants