Fix various issues with graphs and recipes #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

inclement merged 1 commit into kivy:master from unknown repository

Feb 5, 2019

ghost commented Feb 3, 2019 •

edited by ghost

Loading

fix graph depending on capitalization of dependency/recipe names when pip doesn't
fix graph giving no useful errors for conflicts (now it gives them sometimes)
fix graph entering infinite loop when no bootstrap is found
fix recipe not being obtainable irregardless of capitalization
fix recipe IOError-on-doesn't-exist not distinguishable from
recipe-exists-but-code-messes-up-and-causes-unintentional-IOError.
a non-existent recipe will now cause a ValueError
fix the bootstraps' own dependencies being wrong and unused
change preferred default from python2 + sdl2 to python3 + sdl2
possibly other minor fixes I forgot about

(some of these fixes are required for #1625 / project's setup.py to be reasonably used)

ghost changed the title ~~Fixes various issues with graphs and recipes~~ Fix various issues with graphs and recipes

AndreMiras reviewed

View reviewed changes

pythonforandroid/build.py Show resolved Hide resolved

Member

AndreMiras commented Feb 3, 2019

Thanks for making a dedicated one for it. We'll review it more seriously later on.
Did you see that the tox test broke?

AndreMiras reviewed

View reviewed changes

pythonforandroid/bootstraps/webview/__init__.py Outdated Show resolved Hide resolved

Author

ghost commented Feb 3, 2019

@AndreMiras thanks I had to fix some of the unit tests, it should work now!

AndreMiras reviewed

View reviewed changes

pythonforandroid/build.py Outdated Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/bootstraps/service_only/__init__.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Outdated Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Outdated Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Outdated Show resolved Hide resolved

KeyWeeUsr suggested changes

View reviewed changes

pythonforandroid/build.py Outdated Show resolved Hide resolved

pythonforandroid/build.py Show resolved Hide resolved

pythonforandroid/graph.py Outdated Show resolved Hide resolved

pythonforandroid/graph.py Outdated Show resolved Hide resolved

pythonforandroid/graph.py Outdated Show resolved Hide resolved

pythonforandroid/graph.py Outdated Show resolved Hide resolved

pythonforandroid/graph.py Outdated Show resolved Hide resolved

pythonforandroid/graph.py Outdated Show resolved Hide resolved

pythonforandroid/graph.py Outdated Show resolved Hide resolved

pythonforandroid/graph.py Outdated Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/recipe.py Outdated Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

tests/test_graph.py Outdated Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

tests/test_graph.py Outdated Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

Member

AndreMiras left a comment

Thanks for the PR @Jonast it looks once again very good overall! 💪
I left some minor comments and less minor concerns, please let me know what you think.
I think we're almost there, just I prefer to be sure the code looks great since we're touching sensitive components

KeyWeeUsr reviewed

View reviewed changes

pythonforandroid/graph.py Outdated Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

tests/test_graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Outdated Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

tests/test_graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

tests/test_graph.py Outdated Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

pythonforandroid/graph.py Outdated Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

tests/test_graph.py Show resolved Hide resolved

AndreMiras reviewed

View reviewed changes

tests/test_graph.py Show resolved Hide resolved

AndreMiras previously approved these changes

View reviewed changes

Member

AndreMiras left a comment

I'm ready for the merge, thanks for your time and effort 💪
Will merge when build turns green


          Fix various issues with graphs and recipes:

6660b9e

- fix graph depending on capitalization when pip doesn't
- fix graph giving no useful errors (now it gives them sometimes)
- fix graph entering infinite loop when no bootstrap is found
- fix recipe not being obtainable irregardless of capitalization
- fix recipe IOError-on-doesn't-exist not distinguishable from
  code-messes-up-and-causes-true-IOError. a non-existent recipe will
  now cause a ValueError
- fix the bootstraps own dependencies being wrong and unused
- possibly other minor fixes I forgot about

ghost dismissed AndreMiras’s stale review via

6660b9e

February 5, 2019 15:32

KeyWeeUsr approved these changes

View reviewed changes

inclement approved these changes

View reviewed changes

Member

inclement left a comment

Very nice, thanks!

inclement merged commit 50afdf1 into kivy:master

ghost deleted the graphchanges branch

February 8, 2019 03:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet