hack/update-deps.sh not updating eventing submodule correctly in CI

[creydr]

The update-dependencies job does not update the eventing-core submodule correctly while the eventing-kafka-broker submodule is updated correctly.

Pulling branch main for submodule /github/workspace/main/third_party/eventing
Already up to date.

e.g. in https://github.com/knative-extensions/knobots/actions/runs/7114892104/job/19369892442

This needs to be fixed, so that the dependencies get updated correctly again

Resources:

• Action source: https://github.com/knative-extensions/knobots/blob/main/actions/update-deps/action.yaml
• Workflow runs: https://github.com/knative-extensions/knobots/actions/workflows/auto-update-deps.yaml
• False positive workflow run: https://github.com/knative-extensions/knobots/actions/runs/7114892104/job/19369892442
• update-deps script: https://github.com/knative-extensions/eventing-istio/blob/main/hack/update-deps.sh

[pierDipi]

We could try to add more logs as it's currently not clear what is wrong

• log the submodule remote branch in update_submodule
• log current commit sha
• etc

[creydr]

Current log:
The submodules are recognized now correctly after #203.
Anyhow, after hack/update-codegen.sh is run in https://github.com/knative-extensions/knobots/blob/399612e0a785826d9ae4df58edc8e854154a9a8e/actions/update-deps/entrypoint.sh#L65, the changes are not recognized anymore. See https://github.com/knative-extensions/knobots/actions/runs/7256079820/job/19767808948:

On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   go.mod
	modified:   go.sum
	modified:   vendor/modules.txt

[creydr]

unassigned myself if anybody else want to give it a try

[octonawish-akcodes]

Can I try?

[creydr]

sure

[octonawish-akcodes]

/assign

[creydr]

Seems we still have the issues after #236: https://github.com/knative-extensions/knobots/actions/runs/7578178889/job/20640351413

[creydr]

I think I found the problem:
In the update-deps job, we call ./hack/update-codegen.sh too (without parameters!):

https://github.com/knative-extensions/knobots/blob/7927c25f2ad10870e2452ce75b312462b66199ab/actions/update-deps/entrypoint.sh#L65

In eventing-istios ./hack/update-codegen.sh, we call ./hack/update-deps.sh (without parameters):

eventing-istio/hack/update-codegen.sh

Line 59 in 8588c5a

"${REPO_ROOT_DIR}"/hack/update-deps.sh

But as we don't pass the parameters (e.g. --upgrade or some --release info) in the update-deps job and don't pass this in eventing-istios ./hack/update-codegen.sh to ./hack/update-deps.sh, we don't update the submodules:

eventing-istio/hack/update-deps.sh

Lines 34 to 37 in 8588c5a

	function update_submodule() {
	if [ "${upgrade}" = "" ]; then
	return
	fi

Anyhow not really sure yet, how to solve this, besides updating the update-deps job (entrypoint.sh) with passing the same arguments to update-codegen.sh and then pass them through update-deps.sh

@pierDipi: FYI ^

[pierDipi]

Isn't that

• we upgrade deps and submodules here https://github.com/knative-extensions/knobots/blob/7927c25f2ad10870e2452ce75b312462b66199ab/actions/update-deps/entrypoint.sh#L55
• Then we call ./hack/update-codegen.sh and so ./hack/update-deps.sh and that one should keep submodules untouched ?