Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #245

Merged

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Jan 24, 2024

Manually running the update-deps skript via

./hack/update-deps.sh --release 1.13 --module-release 0.40 --upgrade

To get the eventing-core submodule changes for 1.13 (see #178)

/cc @Cali0707 @Leo6Leo @pierDipi

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2024
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@creydr
Copy link
Contributor Author

creydr commented Jan 24, 2024

/retest-required

@Cali0707
Copy link
Member

/test integration-tests

1 similar comment
@Cali0707
Copy link
Member

/test integration-tests

@creydr
Copy link
Contributor Author

creydr commented Jan 25, 2024

/retest-required

@creydr
Copy link
Contributor Author

creydr commented Jan 25, 2024

/test integration-tests

1 similar comment
@creydr
Copy link
Contributor Author

creydr commented Jan 25, 2024

/test integration-tests

@creydr
Copy link
Contributor Author

creydr commented Jan 25, 2024

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
@creydr
Copy link
Contributor Author

creydr commented Jan 26, 2024

Rerun ./hack/update-deps.sh --release 1.13 --module-release 0.40 --upgrade to get latest EKB changes

@Cali0707 @Leo6Leo can you recheck?

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
This has the commit to skip the tests

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
Copy link

knative-prow bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8588c5a into knative-extensions:main Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants