Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] #2704

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[WIP] #2704

wants to merge 3 commits into from

Conversation

gauron99
Copy link
Contributor

@gauron99 gauron99 commented Feb 19, 2025

Get rid of docker.io

fixes #2720

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2025
Copy link

knative-prow bot commented Feb 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot requested a review from jrangelramos February 19, 2025 09:10
Copy link

knative-prow bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from nainaz February 19, 2025 09:10
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2025
@gauron99
Copy link
Contributor Author

/test all

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.33%. Comparing base (1d26629) to head (37596f7).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2704      +/-   ##
==========================================
+ Coverage   64.03%   65.33%   +1.29%     
==========================================
  Files         131      131              
  Lines       15591    15591              
==========================================
+ Hits         9984    10186     +202     
+ Misses       4655     4417     -238     
- Partials      952      988      +36     
Flag Coverage Δ
e2e-test 35.84% <ø> (ø)
e2e-test-oncluster 34.13% <ø> (+1.36%) ⬆️
e2e-test-oncluster-runtime 28.57% <ø> (?)
e2e-test-runtime-go 26.47% <ø> (?)
e2e-test-runtime-node 25.88% <ø> (?)
e2e-test-runtime-python 25.88% <ø> (?)
e2e-test-runtime-quarkus 26.03% <ø> (?)
e2e-test-runtime-rust 24.90% <ø> (?)
e2e-test-runtime-springboot 25.02% <ø> (?)
e2e-test-runtime-typescript 25.98% <ø> (?)
integration-tests 51.93% <ø> (+2.24%) ⬆️
unit-tests 50.90% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: David Fridrich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup: Further remove docker.io registry
1 participant