Skip to content

Mirror buildpack run images in ghcr.io/knative #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

matejvasek
Copy link
Contributor

No description provided.

@matejvasek matejvasek requested review from gauron99 and lkingland April 9, 2025 14:58
@knative-prow knative-prow bot requested a review from jrangelramos April 9, 2025 14:58
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 9, 2025
@knative-prow knative-prow bot requested a review from nainaz April 9, 2025 14:58
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2025
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.43%. Comparing base (c93de80) to head (318e916).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2775      +/-   ##
==========================================
+ Coverage   61.58%   62.43%   +0.84%     
==========================================
  Files         131      131              
  Lines       15793    15793              
==========================================
+ Hits         9726     9860     +134     
+ Misses       5152     4990     -162     
- Partials      915      943      +28     
Flag Coverage Δ
e2e-test 35.34% <ø> (-0.05%) ⬇️
e2e-test-oncluster 33.75% <ø> (+1.46%) ⬆️
e2e-test-oncluster-runtime 28.10% <ø> (?)
e2e-test-runtime-go 25.71% <ø> (?)
e2e-test-runtime-node 25.07% <ø> (?)
e2e-test-runtime-quarkus 25.15% <ø> (?)
e2e-test-runtime-rust 24.66% <ø> (?)
e2e-test-runtime-springboot 24.67% <ø> (?)
e2e-test-runtime-typescript 25.15% <ø> (?)
integration-tests 48.61% <ø> (+1.83%) ⬆️
unit-tests 48.66% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek
Copy link
Contributor Author

@lkingland the failing tests are not related, plz override them.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
Copy link

knative-prow bot commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8a061c4 into knative:main Apr 9, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants