Unregister views to avoid slow oom issue during meter cleanup

[skonto]

Changes

• Unregisters views that cause part of Autoscaler memory usage increases even with total number of ksvcs/revisions kept constant serving#10516, details here: Autoscaler memory usage increases even with total number of ksvcs/revisions kept constant serving#10516 (comment)
  /kind bug

/cc @evankanderson

[knative-prow-robot]

Hi @skonto. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

@skonto: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[skonto]

Unit tests pass locally on my side, need to retest.

[markusthoemmes]

Do we have a reproducer that allows us to more confidently test that we are no longer leaking memory? Can we potentially write a unit(ish) test that makes sure we don't leak memory?

[codecov]

Codecov Report

Merging #2005 (0758c06) into master (ca02ef7) will increase coverage by 0.05%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##           master    #2005      +/-   ##
==========================================
+ Coverage   67.15%   67.20%   +0.05%     
==========================================
  Files         214      214              
  Lines        9091     9102      +11     
==========================================
+ Hits         6105     6117      +12     
- Misses       2711     2712       +1     
+ Partials      275      273       -2     

Impacted Files	Coverage Δ
network/transports.go	86.04% <42.85%> (-6.27%)	⬇️
network/h2c.go	25.00% <66.66%> (+5.00%)	⬆️
controller/controller.go	86.41% <100.00%> (ø)
metrics/resource_view.go	88.63% <100.00%> (+2.08%)	⬆️
webhook/psbinding/psbinding.go	84.61% <100.00%> (ø)
webhook/resourcesemantics/defaulting/defaulting.go	80.86% <100.00%> (ø)
...k/resourcesemantics/validation/reconcile_config.go	89.23% <100.00%> (ø)
test/gcs/mock/mock.go	91.39% <0.00%> (+1.07%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca02ef7...5000a74. Read the comment docs.

[skonto]

@markusthoemmes I added a unit test hope that helps. Not sure if there is way to check this better eg. compare actual mem allocations.

[skonto]

/retest

[knative-prow-robot]

@skonto: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[skonto]

@markusthoemmes could you add /ok-to-test?

[markusthoemmes]

/ok-to-test

[skonto]

/retest

[skonto]

Not sure what is wrong here with the unit tests but they pass locally.

[skonto]

Now I see:

--- FAIL: TestDefaultObserved (0.00s)
    informed_watcher_test.go:392: foo1.count = 1, want 2

[skonto]

/retest

[skonto]

--- FAIL: TestMetricsExport (6.07s)
    --- FAIL: TestMetricsExport/OpenCensus (5.03s)
        e2e_test.go:235: Created exporter at localhost:12345
        logger.go:130: 2021-02-09T19:31:22.391Z	INFO	metrics/exporter.go:161	Flushing the existing exporter before setting up the new exporter.
        logger.go:130: 2021-02-09T19:31:22.398Z	INFO	metrics/opencensus_exporter.go:56	Created OpenCensus exporter with config:	{"config": {}}
        logger.go:130: 2021-02-09T19:31:22.398Z	INFO	metrics/exporter.go:174	Successfully updated the metrics exporter; old config: &{knative.dev/serving testComponent prometheus 1000000000 <nil> <nil>  false 19090 0.0.0.0 false   {   false}}; new config &{knative.dev/serving testComponent opencensus 1000000000 <nil> <nil> localhost:12345 false 0  false   {   false}}
        e2e_test.go:273: Timeout reading input
        e2e_test.go:279: Unexpected OpenCensus exports (-want +got):
              []metrics.metricExtract(Inverse(Sort, []string{
              	"knative.dev/serving/testComponent/global_export_counts<>:2",
              	"knative.dev/serving/testComponent/resource_global_export_count<>:2",
              	`knative.dev/serving/testComponent/testing/value<project="p1",rev`...,
            - 	`knative.dev/serving/testComponent/testing/value<project="p1",revision="r2">:1`,
              }))
{"level":"info","ts":1612899093.698988,"logger":"fallback","caller":"metrics/prometheus_exporter.go:51","msg":"Created Prometheus exporter with config: &{test test prometheus 0 <nil> <nil>  false 0  false   {   false}}. Start the server for Prometheus exporter."}
FAIL 

[skonto]

@julz @vagababov @markusthoemmes should this be merged now? I think the failing test should be handled on its own separately.

[vagababov]

/lgtm

/assign @evankanderson
For Evan to stamp approval.

[skonto]

@evankanderson gentle ping.

[skonto]

@evankanderson @vagababov should we merge? wdyth?

[evankanderson]

/approve
/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• metrics/OWNERS [evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[skonto]

/retest