Skip to content

Interface implementing interface does not generate correct code (Version: 4.0.1) #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MLNW opened this issue Dec 25, 2020 · 1 comment · Fixed by #469
Closed

Interface implementing interface does not generate correct code (Version: 4.0.1) #468

MLNW opened this issue Dec 25, 2020 · 1 comment · Fixed by #469
Assignees
Labels
bug Something isn't working

Comments

@MLNW
Copy link

MLNW commented Dec 25, 2020

Issue Description

When I create an interface that implements another interface like so:

interface Node {
    id: ID!
}

interface Origin implements Node {
    id: ID!
}

The resulting model does not correctly extend the parent interface.

Steps to Reproduce

  • Add two interfaces
  • Extend second interface with first
  • Generate code
  • Check the result

Expected Result

public interface OriginTO extends NodeTO {

    @javax.validation.constraints.NotNull
    String getId();

}

Actual Result

public interface OriginTO {

    @javax.validation.constraints.NotNull
    String getId();

}

Your Environment and Setup

  • graphql-java-codegen: 4.0.1
  • Build tool: Gradle
  • Java tool: 15.0.1

Additional context

Support for interfaces implementing other interfaces has only recently been added to graphql: graphql/graphql-spec#373

@MLNW
Copy link
Author

MLNW commented Dec 28, 2020

Thank you very much for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants