Skip to content

Support interfaces to extend other interfaces #468 #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,15 @@ class FreeMarkerTemplatesRegistry {

try {
EnumMap<FreeMarkerTemplateType, Template> javaTemplates = new EnumMap<>(FreeMarkerTemplateType.class);
javaTemplates.put(TYPE, configuration.getTemplate("templates/javaClassGraphqlType.ftl"));
javaTemplates.put(ENUM, configuration.getTemplate("templates/javaClassGraphqlEnum.ftl"));
javaTemplates.put(UNION, configuration.getTemplate("templates/javaClassGraphqlUnion.ftl"));
javaTemplates.put(REQUEST, configuration.getTemplate("templates/javaClassGraphqlRequest.ftl"));
javaTemplates.put(RESPONSE, configuration.getTemplate("templates/javaClassGraphqlResponse.ftl"));
javaTemplates.put(INTERFACE, configuration.getTemplate("templates/javaClassGraphqlInterface.ftl"));
javaTemplates.put(OPERATIONS, configuration.getTemplate("templates/javaClassGraphqlOperations.ftl"));
javaTemplates.put(PARAMETRIZED_INPUT, configuration.getTemplate("templates/javaClassGraphqlParametrizedInput.ftl"));
javaTemplates.put(RESPONSE_PROJECTION, configuration.getTemplate("templates/javaClassGraphqlResponseProjection.ftl"));
javaTemplates.put(TYPE, configuration.getTemplate("templates/java-lang/javaClassGraphqlType.ftl"));
javaTemplates.put(ENUM, configuration.getTemplate("templates/java-lang/javaClassGraphqlEnum.ftl"));
javaTemplates.put(UNION, configuration.getTemplate("templates/java-lang/javaClassGraphqlUnion.ftl"));
javaTemplates.put(REQUEST, configuration.getTemplate("templates/java-lang/javaClassGraphqlRequest.ftl"));
javaTemplates.put(RESPONSE, configuration.getTemplate("templates/java-lang/javaClassGraphqlResponse.ftl"));
javaTemplates.put(INTERFACE, configuration.getTemplate("templates/java-lang/javaClassGraphqlInterface.ftl"));
javaTemplates.put(OPERATIONS, configuration.getTemplate("templates/java-lang/javaClassGraphqlOperations.ftl"));
javaTemplates.put(PARAMETRIZED_INPUT, configuration.getTemplate("templates/java-lang/javaClassGraphqlParametrizedInput.ftl"));
javaTemplates.put(RESPONSE_PROJECTION, configuration.getTemplate("templates/java-lang/javaClassGraphqlResponseProjection.ftl"));
templateMap.put(GeneratedLanguage.JAVA, javaTemplates);

EnumMap<FreeMarkerTemplateType, Template> scalaTemplates = new EnumMap<>(FreeMarkerTemplateType.class);
Expand All @@ -72,8 +72,6 @@ class FreeMarkerTemplatesRegistry {
kotlinTemplates.put(PARAMETRIZED_INPUT, configuration.getTemplate("templates/kotlin-lang/kotlinClassGraphqlParametrizedInput.ftl"));
kotlinTemplates.put(RESPONSE_PROJECTION, configuration.getTemplate("templates/kotlin-lang/kotlinClassGraphqlResponseProjection.ftl"));
templateMap.put(GeneratedLanguage.KOTLIN, kotlinTemplates);


} catch (IOException e) {
throw new UnableToLoadFreeMarkerTemplateException(e);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

import java.util.HashMap;
import java.util.Map;
import java.util.Set;
import java.util.stream.Collectors;

import static com.kobylynskyi.graphql.codegen.model.DataModelFields.*;

Expand Down Expand Up @@ -40,6 +42,7 @@ public Map<String, Object> map(MappingContext mappingContext, ExtendedInterfaceT
dataModel.put(PACKAGE, DataModelMapper.getModelPackageName(mappingContext));
dataModel.put(CLASS_NAME, dataModelMapper.getModelClassNameWithPrefixAndSuffix(mappingContext, definition));
dataModel.put(JAVA_DOC, definition.getJavaDoc());
dataModel.put(IMPLEMENTS, getInterfaces(mappingContext, definition));
dataModel.put(ANNOTATIONS, graphQLTypeMapper.getAnnotations(mappingContext, definition));
dataModel.put(FIELDS, fieldDefinitionToParameterMapper.mapFields(mappingContext, definition.getFieldDefinitions(), definition));
dataModel.put(GENERATED_INFO, mappingContext.getGeneratedInformation());
Expand All @@ -48,4 +51,12 @@ public Map<String, Object> map(MappingContext mappingContext, ExtendedInterfaceT
return dataModel;
}

private Set<String> getInterfaces(MappingContext mappingContext,
ExtendedInterfaceTypeDefinition definition) {
return definition.getImplements()
.stream()
.map(anImplement -> graphQLTypeMapper.getLanguageType(mappingContext, anImplement))
.collect(Collectors.toSet());
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,13 @@ void generate_CheckFiles() throws Exception {

File[] files = Objects.requireNonNull(outputJavaClassesDir.listFiles());
List<String> generatedFileNames = Arrays.stream(files).map(File::getName).sorted().collect(toList());
assertEquals(Arrays.asList("Bar.java", "Bar1.java", "Foo.java", "Foo1.java"), generatedFileNames);
assertEquals(Arrays.asList("Bar.java", "Bar1.java", "BarBar.java", "Foo.java", "Foo1.java"), generatedFileNames);

for (File file : files) {
assertSameTrimmedContent(new File(String.format("src/test/resources/expected-classes/interfaces/%s.txt",
file.getName())),
file);
}
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ void generate_CheckFiles() throws Exception {

File[] files = Objects.requireNonNull(outputJavaClassesDir.listFiles());
List<String> generatedFileNames = Arrays.stream(files).map(File::getName).sorted().collect(toList());
assertEquals(Arrays.asList("Bar.kt", "Bar1.kt", "Foo.kt", "Foo1.kt"), generatedFileNames);
assertEquals(Arrays.asList("Bar.kt", "Bar1.kt", "BarBar.kt", "Foo.kt", "Foo1.kt"), generatedFileNames);

for (File file : files) {
assertSameTrimmedContent(new File(String.format("src/test/resources/expected-classes/kt/interfaces/%s.txt",
Expand Down
13 changes: 13 additions & 0 deletions src/test/resources/expected-classes/interfaces/BarBar.java.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package com.kobylynskyi.graphql.interfaces;


@javax.annotation.Generated(
value = "com.kobylynskyi.graphql.codegen.GraphQLCodegen",
date = "2020-12-31T23:59:59-0500"
)
public interface BarBar extends Bar{
Copy link
Collaborator

@jxnu-liguobin jxnu-liguobin Dec 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe need add a Space. Next time I'll modify it, it's a template problem

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I will make a note and do this in the next PR.


@javax.validation.constraints.NotNull
String getId();

}
12 changes: 12 additions & 0 deletions src/test/resources/expected-classes/kt/interfaces/BarBar.kt.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.kobylynskyi.graphql.interfaces


@javax.annotation.Generated(
value = ["com.kobylynskyi.graphql.codegen.GraphQLCodegen"],
date = "2020-12-31T23:59:59-0500"
)
interface BarBar : Bar{

val id: String

}
8 changes: 6 additions & 2 deletions src/test/resources/schemas/interfaces.graphqls
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,15 @@ interface Bar {
id: ID!
}

type Foo1 implements Foo{
type Foo1 implements Foo {
id: ID!
bars: [Bar1]
}

type Bar1 implements Bar{
type Bar1 implements Bar {
id: ID!
}

interface BarBar implements Bar {
id: ID!
}