Skip to content

support msg for deprecated #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 29, 2020
Merged

support msg for deprecated #471

merged 5 commits into from
Dec 29, 2020

Conversation

jxnu-liguobin
Copy link
Collaborator

support

directive @deprecated(reason: String = "No longer supported") on FIELD_DEFINITION | ENUM_VALUE

@kobylynskyi kobylynskyi self-assigned this Dec 29, 2020
kobylynskyi
kobylynskyi requested changes Dec 29, 2020
View reviewed changes
Copy link
Owner

@kobylynskyi kobylynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
I have just a few minor comments. If you can address them then we are good to go.

@kobylynskyi kobylynskyi merged commit 9ce4569 into kobylynskyi:master Dec 29, 2020
@jxnu-liguobin jxnu-liguobin deleted the support-deprecated-with-msg branch December 30, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobylynskyi kobylynskyi kobylynskyi approved these changes

Assignees

@kobylynskyi kobylynskyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxnu-liguobin @kobylynskyi