Skip to content

fieldFilter itemValue to filterFields #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

arcadeJHS
Copy link

Pass itemValue object to filterFields function

@kouts kouts self-requested a review August 29, 2023 19:04
@kouts
Copy link
Owner

kouts commented Aug 29, 2023

@arcadeJHS thanks for this PR, I'm not sure if Semantic release will kick in, maybe you can name the commit: feat: passing all data fields to filterfields function just to be sure?

@arcadeJHS
Copy link
Author

@arcadeJHS thanks for this PR, I'm not sure if Semantic release will kick in, maybe you can name the commit: feat: passing all data fields to filterfields function just to be sure?

Thanx! If you will not be able to merge it I will rename it for sure (by the way the comment passed the comment lint check).

@kouts kouts merged commit aaf8b93 into kouts:next Aug 29, 2023
@github-actions
Copy link

🎉 This PR is included in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arcadeJHS arcadeJHS deleted the item-data-in-filter branch August 30, 2023 06:26
@arcadeJHS
Copy link
Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants