Skip to content

Special characters #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolasiensen opened this issue May 13, 2015 · 2 comments
Closed

Special characters #58

nicolasiensen opened this issue May 13, 2015 · 2 comments

Comments

@nicolasiensen
Copy link

Hi!

First of all, congrats for this awesome solution for string diffs.

I'm trying to get the diff between two words that contains special characters, very common in Portuguese and Spanish languages.

For example, the diff between jurídica and física is returning f jur í sica dica, but it should recognize them as completely different words.

If I take off the special character "í" the result is two different words: fisica and juridica.

Is this behavior expected?

Cheers!

@kpdecker
Copy link
Owner

kpdecker commented Jun 3, 2015

This is an artifact of es5 regex behaviors. We should look at the es6
Unicode regex matching and we should look at the poly fill for the interim.
On Wed, May 13, 2015 at 3:46 PM Nícolas Iensen [email protected]
wrote:

Hi!

First of all, congrats for this awesome solution for string diffs.

I'm trying to get the diff between two words that contains special
characters, very common in Portuguese and Spanish languages.

For example, the diff between jurídica and física is returning f jur í `
sica dica, but it should recognize them as completely different words.

If I take off the special character "í" the result is two different words:
fisica and juridica.

Is this behavior expected? If not, I can take a look myself to figure it
out.

Cheers!


Reply to this email directly or view it on GitHub
#58.

@kpdecker
Copy link
Owner

kpdecker commented Aug 4, 2015

Duplicate of #29

@kpdecker kpdecker closed this as completed Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants