-
Notifications
You must be signed in to change notification settings - Fork 510
TypeScript rewrite #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
TypeScript rewrite #591
Conversation
4189aff
to
cb03e0a
Compare
…ing. No longer makes sense.
…eful for compatibility with something, somewhere
Doesn't seem to really affect anything. Output in dist/diff.js is almost identical; just formatting changes and a handful of other things that look inconsequential.
…n into the function comments, so it can show up in people's editors
I think this is ready to merge. But goddamn, it was hard. Everything about this process was like waaaaay harder than expected, but most especially
Probably there were multiple other things I banged my head against a wall for hours on, too - it's been a long time since I started work on this and I've forgotten things. I've tried to review my own code and I reckon I'm happy merging and shipping this, but I'm going to wait at least a week. I'd be very grateful if anyone with more TypeScript expertise than me would be willing to review my work. @isaachinman & @andrewbranch, you seem like obvious candidates though of course you are not under any obligation at all to spend time looking at this. |
Not sure I will have time to review a |
Resolves #303
Resolves #577
See also discussion at #583.
This turned out to be a kind of hellish amount of work, but I think I've cracked it. This should eliminate the need for users to install
@types/diff
and also fix various issues with the types currently on DefinitelyTyped, along with making sure that henceforth there'll be no possibility of type declarations being out of sync with the underlying library. (TypeScript also caught two actual bugs in the library during the course of the rewrite, fixed separately in #601 and #602.)