Skip to content

Fixing wasm-bindgen benchmark #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions frameworks/keyed/wasm-bindgen/.gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
js_framework_benchmark_wasm_bindgen.*
js_framework_benchmark_wasm_bindgen_bg.*
node_modules
/target
/pkg
/wasm-pack.log
/yarn-error.log
8 changes: 3 additions & 5 deletions frameworks/keyed/wasm-bindgen/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ edition = "2018"
crate-type = ["cdylib"]

[dependencies]
wasm-bindgen = "0.2.31"
js-sys = "0.3.5"
wasm-bindgen = "0.2.47"
js-sys = "0.3.24"

[dependencies.web-sys]
version = "0.3.4"
version = "0.3.24"
features = [
'Document',
'DomTokenList',
Expand All @@ -25,6 +25,4 @@ features = [

[profile.release]
lto = true
opt-level = "z"
debug = false
panic = "abort"
14 changes: 14 additions & 0 deletions frameworks/keyed/wasm-bindgen/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
Because of the heavy amount of Rust dependencies, this example is pre-compiled, so you don't need to compile anything.

However, if you do want to compile it, you will need the following:

* [Rust](https://www.rust-lang.org/tools/install)

* [wasm-pack](https://rustwasm.github.io/wasm-pack/)

After installing those, run these commands:

```
npm install
npm run build-prod-force
```
187 changes: 0 additions & 187 deletions frameworks/keyed/wasm-bindgen/build.js

This file was deleted.

2 changes: 1 addition & 1 deletion frameworks/keyed/wasm-bindgen/bundled-dist/1.js

Large diffs are not rendered by default.

Binary file not shown.
Binary file not shown.
1 change: 1 addition & 0 deletions frameworks/keyed/wasm-bindgen/bundled-dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion frameworks/keyed/wasm-bindgen/bundled-dist/main.js

This file was deleted.

Loading