-
Notifications
You must be signed in to change notification settings - Fork 853
updated to remove 772 error and pass the iskeyed test #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I agree with you and thank you very much.
…On Fri, Mar 12, 2021 at 4:34 PM Stefan Krause ***@***.***> wrote:
Thanks! I think it's a great step for AppRun to get rid of #772
<#772>.
But I think I must mark it for using explicit event delegation #801
<#801> in the
click function (which is a much minor issue than #772
<#772>) .
Would you concur?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#861 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABJUM4N62KXF6G3TE7H7KLTDKCG3ANCNFSM4YT54C3A>
.
|
Awesome, thanks!
…On Sat, Mar 13, 2021 at 9:25 AM Stefan Krause ***@***.***> wrote:
Thanks - results are updated. Here's the table with the latest updates:
<https://user-images.githubusercontent.com/3374055/111033165-292b9f80-8410-11eb-87d5-86fdeddeeef0.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#861 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABJUM6Z33NZFJBDLWQQQ4LTDNYWLANCNFSM4YT54C3A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.