Fix folders that include ignored files #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a folder includes a file that has been ignored, then it would almost
always be shown as "ignored", even if the folder also contains files
that have NOT been ignored.
An example file structure:
```
.
├── .gitignore
└── folder
├── ignored.txt
└── not_ignored.txt
```
Where the `.gitignore` file includes the following:
```
folder/ignored.txt
```
This causes the whole `folder/` entry to be marked as "ignored" even
though `not_ignored.txt` is not ignored. This doesn't seem to make sense
to me and I think that a folder should be marked as "ignored" _only_ if
all of the files inside it are ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I've another pull request if you're not too busy.
If a folder includes a file that has been ignored, then it would almost always be shown as "ignored", even if the folder also contains files that have NOT been ignored.
An example file structure:
Where the
.gitignorefile includes the following:This causes the whole
folder/entry to be marked as "ignored" even thoughnot_ignored.txtis not ignored. This doesn't seem to make sense to me and I think that a folder should be marked as "ignored" only if all of the files inside it are ignored.One thing I'm not too sure about is running
expand('%')in every loop iteration -- I'm not sure if it has any performance impact.Visual example:
Without my patch:
With my patch: