Skip to content

Fix Scenario Outline containing header cell string #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

ilangv
Copy link
Contributor

@ilangv ilangv commented Aug 8, 2022

When Scenario Outline name or step contains a string matching a table header cell, codecept execution fails to find the example scenario.

    Scenario Outline: I update calendar day
        Given  I am logged in to calendar
        When I add event on day: <day>
        Then The event shows in reminders

        Examples:
            | day |
            |  2  |

This happens when includeExampleValues: true .
The is because the plugin does a global replace of all header cell strings.

Fixing this issue by updating the regex to only replace strings enclosed with < >

Fix an issue where Scenario Outline name contains or step contains an example header cell causes execution to fail
@ktryniszewski-mdsol
Copy link
Owner

lgtm, I'll merge and push latest version to npm later today

@ilangv
Copy link
Contributor Author

ilangv commented Aug 23, 2022

lgtm, I'll merge and push latest version to npm later today

Hi @ktryniszewski-mdsol . Would you be able to merge this this week ?

@ktryniszewski-mdsol ktryniszewski-mdsol merged commit e2a6178 into ktryniszewski-mdsol:main Aug 23, 2022
@ktryniszewski-mdsol
Copy link
Owner

sorry about that, totally forgot about this

@ilangv ilangv deleted the patch-1 branch August 23, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants