Skip to content

Make use of Cert Flags if Set #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

bootleg224
Copy link
Contributor

The code does not handle the case when Cert Flags are set and Windows is the platform and .net 5 or greater is used

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 10, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 10, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @bootleg224!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 10, 2022
@tg123
Copy link
Member

tg123 commented Jul 11, 2022

please sign cla

should it be added to

cert = new X509Certificate2(cert.Export(X509ContentType.Pkcs12));

as well?

@bootleg224
Copy link
Contributor Author

CLA Signed, and and yes line you identified should also apply cert flags

@tg123
Copy link
Member

tg123 commented Jul 12, 2022

you have make the author of the commit the same email as cla

@bootleg224
Copy link
Contributor Author

I've updated my email in my profile to match the CLA : https://github.com/bootleg224

@tg123
Copy link
Member

tg123 commented Jul 13, 2022

image
github cant figure out the author of this commit

git commit --amend --reset-author

@tg123
Copy link
Member

tg123 commented Aug 21, 2022

ping @bootleg224

Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bootleg224, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 21, 2022
@m3nax
Copy link
Contributor

m3nax commented Sep 14, 2022

ping @bootleg224

@bootleg224
Copy link
Contributor Author

I have signed the CLA it is unclear what else I need to do

@tg123
Copy link
Member

tg123 commented Sep 15, 2022

@bootleg224 could you please git commit --reset-author to set the commit author with sla signed email

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 15, 2022
@tg123
Copy link
Member

tg123 commented Sep 20, 2022

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8dd8a1e into kubernetes-client:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants