-
Notifications
You must be signed in to change notification settings - Fork 301
Make use of Cert Flags if Set #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @bootleg224! |
please sign cla should it be added to csharp/src/KubernetesClient/CertUtils.cs Line 99 in 624ee29
as well? |
CLA Signed, and and yes line you identified should also apply cert flags |
you have make the author of the commit the same email as cla |
I've updated my email in my profile to match the CLA : https://github.com/bootleg224 |
ping @bootleg224 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bootleg224, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ping @bootleg224 |
I have signed the CLA it is unclear what else I need to do |
@bootleg224 could you please |
/LGTM |
The code does not handle the case when Cert Flags are set and Windows is the platform and .net 5 or greater is used