Skip to content

switched openapi generator to latest v5.1.0 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2021
Merged

switched openapi generator to latest v5.1.0 #189

merged 1 commit into from
Apr 26, 2021

Conversation

yliaog
Copy link
Contributor

@yliaog yliaog commented Apr 21, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2021
@yliaog
Copy link
Contributor Author

yliaog commented Apr 21, 2021

/cc @roycaihw

@k8s-ci-robot k8s-ci-robot requested a review from roycaihw April 21, 2021 17:36
@yliaog
Copy link
Contributor Author

yliaog commented Apr 21, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2021
@roycaihw
Copy link
Member

roycaihw commented Apr 21, 2021 •
edited
Loading

Thanks for holding. I'd like to keep our in-flight v17 Python client releases using the same client generator version. It would be great if we can merge this after we have a stable v17 release.

But technically we should be able to configure the value in the Python repo, so we can merge this if other clients need this.

@roycaihw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2021
@brendandburns
Copy link
Contributor

/approve

But I think the best practice is for each client library to specify their own commit hash so that the behavior is deterministic per-library.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yliaog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brendandburns
Copy link
Contributor

/hold remove

@brendandburns
Copy link
Contributor

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2021
@brendandburns
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2021
@brendandburns
Copy link
Contributor

@roycaihw let me know when this is ready to merge (or just un-hold it yourself)

@yue9944882
Copy link
Member

+1 bumping generator for java

@roycaihw
Copy link
Member

/hold cancel

Sorry for the late reply. The python client release doesn't block this.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 65a1e47 into kubernetes-client:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@yue9944882 yue9944882 Awaiting requested review from yue9944882

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump openapi-generator version in a future pre-release
5 participants
@yliaog @roycaihw @brendandburns @k8s-ci-robot @yue9944882