Initial implementation of Exec. #21
Conversation
brendandburns
force-pushed
the
exec
branch
6 times, most recently
from
956dea2 to
7a5fed8
Compare
|
@mbohlool Now that websockets support is merged, I rebased this on top of that PR. Please take a look. Thanks! |
|
@mbohlool friendly ping on this if you have any feedback. Thanks! |
examples/pom.xml
Outdated
| @@ -19,6 +19,13 @@ | |||
| <artifactId>client-java-util</artifactId> | |||
| <version>1.0-SNAPSHOT</version> | |||
| </dependency> | |||
| <!-- https://mvnrepository.com/artifact/com.google.guava/guava --> | |||
There was a problem hiding this comment.
I can still see the indentation problem here.
| } | ||
|
|
||
| public void destroy() { | ||
| // TODO implementation here |
There was a problem hiding this comment.
Implemented :)
| @@ -26,6 +26,8 @@ | |||
|
|
|||
| import javax.net.ssl.KeyManager; | |||
|
|
|||
| import org.apache.commons.codec.binary.Base64; | |||
There was a problem hiding this comment.
unused import. is there a way to detect these automatically in a github check? like a linter?
There was a problem hiding this comment.
I can't find a good one. Eclipse will do it, but then I'd have to use eclipse :)
|
|
||
| import static java.util.concurrent.TimeUnit.SECONDS; | ||
|
|
||
| public final class WebSocketCall { |
There was a problem hiding this comment.
where did you use this? I see one WebSocketCall in WebSockets.java but it is not using this class. it uses WebSocketCall in another package.
There was a problem hiding this comment.
Removed. (it was part of the GET vs. POST discussion)
| public void onOpen(WebSocket webSocket, Response response) { | ||
| listener.open(); | ||
| public void onOpen(final WebSocket webSocket, Response response) { | ||
| listener.open("todo", new Closeable() { |
There was a problem hiding this comment.
Implemented. thanks for the reminder.
|
Comments addressed, please re-check. Thanks! |
examples/pom.xml
Outdated
| @@ -19,6 +19,13 @@ | |||
| <artifactId>client-java-util</artifactId> | |||
| <version>1.0-SNAPSHOT</version> | |||
| </dependency> | |||
| <!-- https://mvnrepository.com/artifact/com.google.guava/guava --> | |||
There was a problem hiding this comment.
I can still see the indentation problem here.
|
@mbohlool oops, sorry, I formatted the Thanks! |
Depends on #19
Fixes #9