Support multiple expires-on field formats

[fatal-exception]

expires-on field in config can be an int or a time-string.

Existing code only supports an int, but some tools, such as aks-engine AAD integration for Kubernetes, write a time into this field as a string. Here the code is updated to support either int or '%Y-%m-%d %H:%M:%S.%f' in this field

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fatal-exception
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: roycaihw

If they are not already assigned, you can assign the PR to them by writing /assign @roycaihw in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fatal-exception]

This addresses #84

[fatal-exception]

testing CLA signing

[fatal-exception]

Is someone able to help me get this reviewed? I wonder if @mbohlool has any bandwidth? Thanks!

[yliaog]

please add a test case in kube_config_test.py, also fix the CI build failure. Thanks.

[fatal-exception]

Thanks, I guess these are the errors I need to address for the build to pass?

/tmp/tmp.0BLfd3Rq99/python/kubernetes/config/kube_config.py:233:80: E501 line too long (86 > 79 characters)
/tmp/tmp.0BLfd3Rq99/python/kubernetes/config/kube_config_test.py:1120:80: E501 line too long (96 > 79 characters)
/tmp/tmp.0BLfd3Rq99/python/kubernetes/watch/watch_test.py:81:80: E501 line too long (86 > 79 characters)
/tmp/tmp.0BLfd3Rq99/python/kubernetes/../examples/remote_cluster.py:26:80: E501 line too long (94 > 79 characters)
diff --git a/kubernetes/base/config/kube_config.py b/kubernetes/base/config/kube_config.py

I only touched one of these files, the kube_config.py, but I'm happy to fix all the errors if that's needed?

[fatal-exception]

corrected the top 3, i can't se remote_cluster.py file in this repo

[fatal-exception]

I have added tests but not had a chance to run them - is there any documentation on how to run? If I try run_tox.sh I get the error that $TOXENV is unset. If I try to run kube_config_test.py directly, I get this error:

Traceback (most recent call last):
  File "kube_config_test.py", line 32, in <module>
    from .config_exception import ConfigException
ValueError: Attempted relative import in non-package

Trying with Python 2.7.16 as I can see the library mock is used, not unittest.mock

Thanks!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[roycaihw]

a lot of the test failures are from pycodestyle: https://travis-ci.org/kubernetes-client/python-base/builds/530795260?utm_source=github_status&utm_medium=notification

you can run pycodestyle locally and fix the code

[micw523]

Try autopep8 agressive level 2 - that’s how we’re checking the code style right now.

[fooka03]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[k8s-ci-robot]

@fatal-exception: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[roycaihw]

Closing due to inactivity. Please reopen if needed

/close

[k8s-ci-robot]

@roycaihw: Closed this PR.

In response to this:

Closing due to inactivity. Please reopen if needed

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.