Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Migrate to pytest #167

Merged

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Oct 2, 2019

As discussed previously, this replaces nose test runner with pytest.
This way there is a uniform toolset for python and python-base.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2019
@oz123
Copy link
Contributor Author

oz123 commented Oct 2, 2019

This is a fix for #153

@micw523
Copy link
Contributor

micw523 commented Oct 2, 2019

/lgtm
This lgtm to me.
Although, nosetests is still being used in the main repo to provide access to the code coverage reports of the base repo. This could also be switched to pytest as well -https://github.com/codecov/example-python

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2019
@yliaog
Copy link
Contributor

yliaog commented Oct 2, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oz123, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit afd1301 into kubernetes-client:master Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants