Delete kubernetes resources from yaml files , solves #940 #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

DiptoChakrabarty wants to merge 3 commits into kubernetes-client:master from DiptoChakrabarty:delete_yaml

Contributor

DiptoChakrabarty commented Mar 16, 2021

This is a method to delete kubernetes resources using the yaml files . It is similar to the method create_from_yaml but for deleting kubernetes resources .
It can be used to any type pf resource deployment , pod , service etc.
Fixes #940

create_from_yaml creates kubernetes objects like deployments,serivces,ingress etc from the given yml files , the delete_from_yaml method can be used to remove/delete those objects from the same yml files in the given cluster for any namespace

k8s-ci-robot added the cncf-cla: yes label

k8s-ci-robot requested review from roycaihw and yliaog

March 16, 2021 03:36

k8s-ci-robot added the size/L label

Contributor Author

DiptoChakrabarty commented Mar 19, 2021

hey all the tests are passing for my branch in my repo

However in the master branch the test_portforward_raw.py test seems to be failing only causing the travis build to fail , I havent done any changes to that file

What can I do since I havent edited that file

Contributor

yliaog commented Mar 19, 2021

test_portforward_raw is flaky, we have an issue to track fixing it.

closing to trigger CI
/close

k8s-ci-robot closed this

Contributor

k8s-ci-robot commented Mar 19, 2021

@yliaog: Closed this PR.

In response to this:

test_portforward_raw is flaky, we have an issue to track fixing it.

closing to trigger CI
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

yliaog commented Mar 19, 2021

/reopen

k8s-ci-robot reopened this

Contributor

k8s-ci-robot commented Mar 19, 2021

@yliaog: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Member

roycaihw commented Mar 29, 2021

/assign @yliaog

k8s-ci-robot assigned yliaog

yliaog reviewed

View reviewed changes

Contributor

yliaog left a comment

it is mostly duplicates from create_from_yaml, better to refactor it into a common file, then have create_from_yaml, and delete_from_yaml share the common util, instead of having duplicates between them.

kubernetes/utils/delete_from_yaml.py

		@@ -0,0 +1,146 @@
		# Copyright 2018 The Kubernetes Authors.

Contributor

yliaog Mar 29, 2021

s/2018/2021/

kubernetes/utils/delete_from_yaml.py Outdated

+              def delete_from_yaml(k8s_client, yaml_file, verbose=False,
+                                   namespace="default", **kwargs):
+                  """Input:

Contributor

yliaog Mar 29, 2021

better to describe what the function does before the Input:

Contributor Author

DiptoChakrabarty Apr 4, 2021

okay will modify and push

kubernetes/utils/delete_from_yaml.py

+                  k8s_client: an ApiClient object, initialized with the client args.
+                  verbose: If True, print confirmation from the create action.
+                      Default is False.
+                  namespace: string. Contains the namespace to create all

Contributor

yliaog Mar 29, 2021

s/create/delete/

kubernetes/utils/delete_from_yaml.py

+                      Default is False.
+                  namespace: string. Contains the namespace to create all
+                      resources inside. The namespace must preexist otherwise
+                      the resource creation will fail. If the API object in

Contributor

yliaog Mar 29, 2021

s/creation/deletion/ ?

kubernetes/utils/delete_from_yaml.py

+                      the resource creation will fail. If the API object in
+                      the yaml file already contains a namespace definition
+                      this parameter has no effect.
+                  Available parameters for creating <kind>:

Contributor

yliaog Mar 29, 2021

s/creating/deleting/

kubernetes/utils/delete_from_yaml.py

+                      should not be persisted. An invalid or unrecognized dryRun
+                      directive will result in an error response and no further
+                      processing of the request.
+                      Valid values are: - All: all dry run stages will be processed

Contributor

yliaog Mar 29, 2021

Returns:?

does it return anything?

Contributor Author

DiptoChakrabarty Apr 4, 2021

no it does not return anything , just deletes the resource

kubernetes/utils/delete_from_yaml.py Outdated

+                      failures = []
+                      for yml_document in yml_document_all:
+                          try:
+                              # call delete from dict function

Contributor

yliaog Mar 29, 2021

the comment above is not very useful

kubernetes/utils/delete_from_yaml.py



		def delete_from_dict(k8s_client, yml_document, verbose,
		namespace="default", **kwargs):

Contributor

yliaog Mar 29, 2021

add comments about what it does, Input, Returns etc

Contributor Author

DiptoChakrabarty Apr 4, 2021

sure will do

kubernetes/utils/delete_from_yaml.py Outdated

+                          except client.rest.ApiException as api_exception:
+                              api_exceptions.append(api_exception)
+                  else:

Contributor

yliaog Mar 29, 2021

why extra blank line?

Contributor

k8s-ci-robot commented Apr 4, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DiptoChakrabarty
To complete the pull request process, please ask for approval from yliaog after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor Author

DiptoChakrabarty commented May 22, 2021

hey since this is solving the issue of #940 deleting resources using yaml maintainers can this be merged pleased

Contributor

yliaog commented May 22, 2021

it is mostly duplicates from create_from_yaml, better to refactor it into a common file, then have create_from_yaml, and delete_from_yaml share the common util.

Contributor Author

DiptoChakrabarty commented May 23, 2021

it is mostly duplicates from create_from_yaml, better to refactor it into a common file, then have create_from_yaml, and delete_from_yaml share the common util.

Can this not be a new issue as this PR is solving the issue of deleting using yamls feature and a common file would be a new enhancement

Member

palnabarun commented May 27, 2021

@DiptoChakrabarty -- I agree with @yliaog. It's better to address the duplication of logic in this PR itself. I wouldn't say that deduplication of logic is a new enhancement.

palnabarun mentioned this pull request

Delete from yaml #1197

Closed

Contributor Author

DiptoChakrabarty commented Jun 8, 2021

@DiptoChakrabarty -- I agree with @yliaog. It's better to address the duplication of logic in this PR itself. I wouldn't say that deduplication of logic is a new enhancement.

Okay I am working on it

k8s-ci-robot added size/XL and removed size/L labels

Contributor Author

DiptoChakrabarty commented Jun 10, 2021

I made a new file operate_from_yaml which has both the create and delete features as requested. Please tell me if I have to add anything more in it.

DiptoChakrabarty force-pushed the delete_yaml branch from b9de90f to 58d6b0c Compare

June 20, 2021 18:10

Contributor Author

DiptoChakrabarty commented Jun 21, 2021

hey I have rebased it

mohammedi-haroune commented Jun 28, 2021 •

edited

Loading

Hi, any plans to merge this and release it?

Contributor Author

DiptoChakrabarty commented Jul 3, 2021

Hey @reviewers can you please review this and tell what I have to do next or any suggestions

k8s-ci-robot added the needs-rebase label

DiptoChakrabarty requested a review from yliaog

July 21, 2021 11:26

k8s-ci-robot added the lifecycle/rotten label

Contributor Author

DiptoChakrabarty commented Jun 3, 2022

/remove-lifecycle rotten

k8s-ci-robot removed the lifecycle/rotten label

WIRUT reviewed

View reviewed changes

kubernetes/utils/operate_from_yaml.py


		def delete_k8s_object(k8s_api, yml_document, kind, **kwargs):

		if hasattr(k8s_api, "create_namespaced_{0}".format(kind)):

WIRUT Jun 15, 2022

Is the "create_namespaceD_{0}" here intentional? Should it not be "delete_namespaced_{0}"?

k8s-triage-robot commented Sep 13, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-ci-robot added the lifecycle/stale label

k8s-triage-robot commented Oct 13, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-ci-robot added lifecycle/rotten and removed lifecycle/stale labels

k8s-triage-robot commented Nov 13, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot closed this

Contributor

k8s-ci-robot commented Nov 13, 2022

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dofmind commented Nov 16, 2022 •

edited

Loading

Any update?

dofmind commented Nov 16, 2022

/reopen

Contributor

k8s-ci-robot commented Nov 16, 2022

@dofmind: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

modzilla99 commented Jan 26, 2023

This feature would definitely be very welcome! Please reopen!

charlesmelby commented Jun 19, 2023

Any plans to finish this? It would be quite useful.

stefan-falk-dt commented Sep 6, 2023

@DiptoChakrabarty @roycaihw is this PR still on the table?

modzilla99 commented Sep 6, 2023

Jup it would be very nice to have!

jamesjallorina commented Oct 3, 2023

Why this PR has not been merged? It would be nice to have this feature. Thank you!

jamesjallorina commented Oct 6, 2023

/reopen

Contributor

k8s-ci-robot commented Oct 6, 2023

@jamesjallorina: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jamesjallorina commented Oct 6, 2023

Anyway, I was able to use the author's implementation. Just create a package (e.g kubernetes_workaround) and copy the changes, no need to do some extra tweaking. Thanks!

chrisabbott commented Mar 5, 2024 •

edited

Loading

Will this feature ever be supported? It has been requested numerous times over the past three years, seems like a logical counterpart to create_from_yaml, and blocks many Python client use-cases. I would be happy to open another PR for this if there's interest from others.

dgimeno777 commented Oct 28, 2024

Will this feature ever be supported? It has been requested numerous times over the past three years, seems like a logical counterpart to create_from_yaml, and blocks many Python client use-cases. I would be happy to open another PR for this if there's interest from others.

Seconding this. Without the mirrored ability to tear down resources the create_from_yaml function and Python client itself feels very limited.

kocarba added a commit to kocarba/k8s-python that referenced this pull request


          Revive PR kubernetes-client#1392: Implement delete_from_yaml (origina…

34e1024

…l by DiptoChakrabarty) and update to latest

kocarba added a commit to kocarba/k8s-python that referenced this pull request


          Revive PR kubernetes-client#1392: Implement delete_from_yaml (origina…

5876fe3

…l by DiptoChakrabarty) and update to latest

Revive PR kubernetes-client#1392: Implement delete_from_yaml, solves kubernetes-client#940 (original by DiptoChakrabarty) and update to latest

kocarba added a commit to kocarba/k8s-python that referenced this pull request


          Revive PR kubernetes-client#1392: solves kubernetes-client#940 and up…

73adbb4

…date to latest

(original by DiptoChakrabarty)

- Implement delete_from_yaml functionality
- Combine create_from_yaml and delete_from_yaml into yaml_processor, preserving existing signatures for create

kocarba added a commit to kocarba/k8s-python that referenced this pull request


          Revive PR kubernetes-client#1392: solves kubernetes-client#940 and up…

73aeb93

…date to latest

(original by @DiptoChakrabarty)

- Implement delete_from_yaml functionality
- Combine create_from_yaml and delete_from_yaml into yaml_processor, preserving existing signatures for create

kocarba mentioned this pull request

feat: add yaml processor to create/delete resources from yaml manifest files #2377

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes kind/feature lifecycle/rotten needs-rebase release-note-none size/XL