Release v18.17.0a1 #1411
Merged
Release v18.17.0a1 #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…architecture independent
…ed 'kubernetes.leaderelection' error
To reproduce: Make sure to create a file outside of checked out python repo directory.
$ cat hello_k8s.py
import kubernetes
kubernetes.config.load_kube_config()
k8s = kubernetes.client.CoreV1Api()
print("Listing pods with their IPs:")
ret = k8s.list_pod_for_all_namespaces(watch=False)
for i in ret.items:
print("%s\t%s\t%s" % (i.status.pod_ip, i.metadata.namespace, i.metadata.name))
python hello_k8s.py
Traceback (most recent call last):
File "hello_k8s.py", line 1, in <module>
import kubernetes
File "<frozen zipimport>", line 259, in load_module
File "anaconda3/lib/python3.8/site-packages/kubernetes-17.0.0_snapshot-py3.8.egg/kubernetes/__init__.py", line 25, in <module>
ModuleNotFoundError: No module named 'kubernetes.leaderelection'
- move regex compilation to the top of the module to enable caching.
Use get_default_copy() API with configuration.
kubernetes 1.18 is no longer maintained. 1.18.17 was the last patch release.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
yliaog
reviewed
Apr 12, 2021
| @@ -42,6 +42,9 @@ SETTING_FILE="${TEMP_FOLDER}/settings" | |||
| echo "export KUBERNETES_BRANCH=\"$(python ${SCRIPT_ROOT}/constants.py KUBERNETES_BRANCH)\"" > $SETTING_FILE | |||
| echo "export CLIENT_VERSION=\"$(python ${SCRIPT_ROOT}/constants.py CLIENT_VERSION)\"" >> $SETTING_FILE | |||
| echo "export PACKAGE_NAME=\"client\"" >> $SETTING_FILE | |||
| # Workaround for https://github.com/kubernetes-client/gen/pull/183. | |||
| # The env is required by not used by python client. | |||
| echo "export LIBRARY=\"undefined\"" >> $SETTING_FILE | |||
There was a problem hiding this comment.
should this be added to 'master' branch?
There was a problem hiding this comment.
hopefully not once kubernetes-client/gen#187 is merged. I filed #1412 to track documenting the issue.
There was a problem hiding this comment.
s/The env is required by not used by python client/The env is required but not used by python client/
|
v17 and v18 snapshots are in different branches, why would that cause conflicts when pulling from master into release branch? |
I think it's because the 18.0 snapshot is not in the master branch, and the master branch has the 17.0 snapshot. Pulling master from An example conflict: git thinks a lot of files are modified by both branches: |
|
the current release process does not support multiple parallel releasing well, better to document your release process for v18, so v19 and v20 can follow the same steps. |
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
Filed #1414 to track documenting the release process. I will try getting to it today or tomorrow. |
the env is not used by the python client.
removed the generated test directory following the hot issue (https://github.com/kubernetes-client/python/blob/master/devel/release.md#hot-issues): 4. Remove the tests directory
Reference: - [kubernetes-client#866](kubernetes-client#866) - [kubernetes-client#959](kubernetes-client#959) Signed-off-by: Nabarun Pal <[email protected]>
Reference: kubernetes-client#974 Signed-off-by: Nabarun Pal <[email protected]>
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel the documentation tasks don't block this PR |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it quite hard to resolve the conflicts when pulling master into the release branch. The conflict was caused by we generating v17 and v18 snapshots in parallel. As a workaround I cherrypicked important changes in the master branch into the release branch.