Skip to content

Update master branch to 9.0.0-snapshot client #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

roycaihw
Copy link
Member

@roycaihw roycaihw commented Dec 8, 2018

This PR updates python-base submodule and generates client for 9.0.0-snapshot.

The next step is to fork a release-9.0 branch from master and re-generate the client with version constant updates.

/assign @yliaog

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2018
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 8, 2018
@roycaihw
Copy link
Member Author

roycaihw commented Dec 8, 2018

/hold

adding CHANGELOG for v6.1.0 and v8.0.1

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2018
@roycaihw
Copy link
Member Author

roycaihw commented Dec 8, 2018

/hold cancel

CHANGELOG added

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2018
@@ -268,18 +268,18 @@ def delete_collection_initializer_configuration_with_http_info(self, **kwargs):
_request_timeout=params.get('_request_timeout'),
collection_formats=collection_formats)

def delete_initializer_configuration(self, name, body, **kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it’s potentially going to break some codes if they called the function with func(name, body). Now user needs to call with func(name, body=xxx)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all delete methods will have this change. Probably want to document this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was documented in API change. I added a duplicate of the body param changelog in Breaking Change.

@@ -83,17 +83,18 @@ supported versions of Kubernetes clusters.

#### Compatibility matrix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we indicate that we drop v6 support here or in the actual release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support 3 stable releases, so we will drop v6 support after we release v9 GA version.

@yliaog
Copy link
Contributor

yliaog commented Dec 27, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit 30c3522 into kubernetes-client:master Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants