-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Update master branch to 9.0.0-snapshot client #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update master branch to 9.0.0-snapshot client #698
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold adding CHANGELOG for v6.1.0 and v8.0.1 |
/hold cancel CHANGELOG added |
@@ -268,18 +268,18 @@ def delete_collection_initializer_configuration_with_http_info(self, **kwargs): | |||
_request_timeout=params.get('_request_timeout'), | |||
collection_formats=collection_formats) | |||
|
|||
def delete_initializer_configuration(self, name, body, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it’s potentially going to break some codes if they called the function with func(name, body). Now user needs to call with func(name, body=xxx)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all delete methods will have this change. Probably want to document this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was documented in API change. I added a duplicate of the body param changelog in Breaking Change.
@@ -83,17 +83,18 @@ supported versions of Kubernetes clusters. | |||
|
|||
#### Compatibility matrix | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we indicate that we drop v6 support here or in the actual release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We support 3 stable releases, so we will drop v6 support after we release v9 GA version.
/lgtm |
This PR updates python-base submodule and generates client for 9.0.0-snapshot.
The next step is to fork a release-9.0 branch from master and re-generate the client with version constant updates.
/assign @yliaog