-
Notifications
You must be signed in to change notification settings - Fork 39
The hand-written tests is deleted on re-generation #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ackintosh
added a commit
to OpenAPITools/gen
that referenced
this issue
Feb 23, 2019
ackintosh
added a commit
to OpenAPITools/gen
that referenced
this issue
Feb 23, 2019
in order to avoid unintensional deletion of hand-written test codes. ref kubernetes-client/ruby#29
k8s-ci-robot
pushed a commit
to kubernetes-client/gen
that referenced
this issue
Feb 25, 2019
* Exclude test files from code generation ref kubernetes-client/ruby#29 * Exclude spec folder from cleanup in order to avoid unintensional deletion of hand-written test codes. ref kubernetes-client/ruby#29
kubernetes-client/gen#104 has been merged. 😌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
$ cd kubernetes-client/gen/openapi $ ruby.sh path/to/kubernetes-client/ruby/kubernetes/ path/to/kubernetes-client/ruby/settings ... ... [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 20.620 s [INFO] Finished at: 2019-02-17T08:56:27Z [INFO] ------------------------------------------------------------------------ ---Done. ---Done.
I guessing that the deleted files under
spec
folder are hand-written codes, and those were deleted by the code generation step here.Suggestion
I think generating spec files is not necessary as the auto-generated files under
spec
are just skelton.spec
from hereWhat do you think about it? I would file a PR if the suggestion is OK.
The text was updated successfully, but these errors were encountered: