-
Notifications
You must be signed in to change notification settings - Fork 220
Fix errors in deploy script #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: John Strunk <[email protected]>
- version_gt was not properly stripping the 'kubernetes-' prefix - The kubernetes version (from the deployment directory name) was not being passed to version_gt to determine whether the snapshot class should be deployed. Signed-off-by: John Strunk <[email protected]>
Welcome @JohnStrunk! |
Hi @JohnStrunk. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-kubernetes-csi-csi-driver-host-path-1-16-on-kubernetes-1-16 |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnStrunk, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When using the deploy script, it generated the following error:
version_gt
was also being passed an incorrect value, and the function itself was not properly stripping thekubernetes-
prefix from the passed values.Previously, the
snapshotclass.yaml
was never being deployed.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: