Remove redundant alias import and replace few function names in ISCSI server #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
cncf-cla: yes
humblec
changed the title
ddebroy
reviewed
May 11, 2021
| @@ -3,8 +3,8 @@ package v1beta1 | |||
| // Add manual conversion functions here to override automatic conversion functions | |||
|
|
|||
| import ( | |||
| v1beta1 "github.com/kubernetes-csi/csi-proxy/client/api/disk/v1beta1" | |||
There was a problem hiding this comment.
I think these have been bubbling up since v1alpha1: https://github.com/kubernetes-csi/csi-proxy/blob/master/internal/server/disk/internal/v1alpha1/conversion.go#L6 . Can you please apply the fix in v1alpha1 as well?
There was a problem hiding this comment.
Sure.. Updated patch set. PTAL. Thanks @ddebroy
k8s-ci-robot
added
the
needs-rebase
… server Signed-off-by: Humble Chirammal <[email protected]>
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ddebroy, humblec The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
pohly
added a commit
to pohly/csi-proxy
that referenced
this pull request
May 21, 2021
95eac33 Merge pull request kubernetes-csi#137 from pohly/fix-go-version-check 437e431 verify-go-version.sh: fix check after removal of travis.yml git-subtree-dir: release-tools git-subtree-split: 95eac33629ea9c586c4efcb7ad875191162464b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Humble Chirammal [email protected]