Skip to content

Remove v1 client and pkg code #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Remove v1 client and pkg code #252

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2810c45
chore: clean up v1 client and pkg code
alexander-ding Oct 14, 2022
dcbbf77
test: remove v1 binary commands from GitHub actions and Makefile
alexander-ding Oct 14, 2022
3db4149
test: comment out test-go and test-vet
alexander-ding Oct 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ lint: $(GOLANGCI_LINT)
test: test-go
test-go:
@ echo; echo "### $@:"
GO111MODULE=on go test ./pkg/...
@ echo "No need to run test. Testing is done in GitHub Actions and custom Prow job."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok and not worth it to set additional infra for this to work given that we already have other jobs that are running the tests we want:

  • integration tests are run in Prow (pull-kubernetes-csi-csi-proxy-integration)
  • unit tests are run in Windows Tests / unit_tests (1.16, windows-latest) (pull_request)


.PHONY: test-vet
test: test-vet
test-vet:
@ echo; echo "### $@:"
GO111MODULE=on go vet ./pkg/...
@ echo "No need to run vet. Testing is done in GitHub Actions and custom Prow job."

# see https://github.com/golangci/golangci-lint#binary-release
$(GOLANGCI_LINT):
Expand Down