Skip to content

Update the github action workflow to run the integration tests #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

Update the github action workflow to run the integration tests #348

merged 1 commit into from
Oct 24, 2024

Conversation

mauriciopoppe
Copy link
Member

@mauriciopoppe mauriciopoppe commented Jun 26, 2024 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

What this PR does / why we need it:
A presubmit is failing because of a change in the github actions default Windows VM https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/, I used the same code in scripts/run-integration.sh rewritten in powershell.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 26, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 26, 2024
@mauriciopoppe mauriciopoppe force-pushed the fix-github-actions branch 2 times, most recently from 7ca18a0 to 8f5569a Compare July 25, 2024 20:24
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2024
@mauriciopoppe mauriciopoppe mentioned this pull request Aug 20, 2024
Closed
@andyzhangx andyzhangx closed this Sep 5, 2024
@andyzhangx andyzhangx reopened this Sep 5, 2024
@mauriciopoppe
Copy link
Member Author

@andyzhangx do you have an idea of how to enable the PS Security module again? There was a change in github actions and a presubmit that used to pass no longer passes.

This was referenced Oct 10, 2024
Closed
Closed
@mauriciopoppe mauriciopoppe force-pushed the fix-github-actions branch 3 times, most recently from c7a552c to 41d2e4e Compare October 23, 2024 03:23
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2024
@mauriciopoppe mauriciopoppe force-pushed the fix-github-actions branch 3 times, most recently from 30ea266 to 3b62fa5 Compare October 23, 2024 03:28
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2024
@mauriciopoppe mauriciopoppe force-pushed the fix-github-actions branch 11 times, most recently from d0dc54a to 353eef2 Compare October 23, 2024 14:42
@mauriciopoppe mauriciopoppe changed the title Import PS Security module 3.0 before running a PS function Update the github action workflow to run the integration tests Oct 23, 2024
@mauriciopoppe
Copy link
Member Author

/cc @andyzhangx
/uncc @sunnylovestiramisu @gnufied

@k8s-ci-robot k8s-ci-robot requested review from andyzhangx and removed request for gnufied and sunnylovestiramisu October 23, 2024 14:50
andyzhangx
andyzhangx approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andyzhangx,mauriciopoppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a5d0aa1 into kubernetes-csi:master Oct 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauriciopoppe @k8s-ci-robot @andyzhangx