-
Notifications
You must be signed in to change notification settings - Fork 78
Add wrapper script for sidecar release #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,129 @@ | ||
#!/bin/sh | ||
|
||
# Copyright 2023 The Kubernetes Authors. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
|
||
# Usage: go-modules-update.sh | ||
# | ||
# Batch update dependencies for sidecars. | ||
# | ||
# Required environment variables | ||
# CSI_RELEASE_TOKEN: Github token needed for generating release notes | ||
# GITHUB_USER: Github username to create PRs with | ||
# | ||
# Instructions: | ||
# 1. Login with "gh auth login" | ||
# 2. Copy this script to the kubernetes-csi directory (one directory above the | ||
# repos) | ||
# 3. Update the repos and master branch so locally it has the latest upstream | ||
# change | ||
# 4. Set environment variables | ||
# 5. Run script from the kubernetes-csi directory | ||
# | ||
# Caveats: | ||
# - This script doesn't handle interface incompatibility of updates. | ||
# You need to resolve interface incompatibility case by case. The | ||
# most frequent case is to update the interface(new parameters, | ||
# name change of the method, etc.)in the sidecar repo and make sure | ||
# the build and test pass. | ||
|
||
|
||
set -e | ||
set -x | ||
|
||
MAX_RETRY=10 | ||
|
||
# Get the options | ||
while getopts ":u:v:" option; do | ||
case $option in | ||
u) # Set username | ||
username=$OPTARG;; | ||
v) # Set version | ||
v=$OPTARG;; | ||
\?) # Invalid option | ||
echo "Error: Invalid option: $OPTARG" | ||
exit;; | ||
esac | ||
done | ||
|
||
# Only need to do this once | ||
gh auth login | ||
|
||
while read -r repo branches; do | ||
if [ "$repo" != "#" ]; then | ||
( | ||
cd "$repo" | ||
git fetch origin | ||
for i in $branches; do | ||
if [ "$(git rev-parse --verify "module-update-$i" 2>/dev/null)" ]; then | ||
git checkout master && git branch -d "module-update-$i" | ||
fi | ||
git checkout -B "module-update-$i" "origin/$i" | ||
rm -rf .git/MERGE* | ||
if ! git subtree pull --squash --prefix=release-tools https://github.com/kubernetes-csi/csi-release-tools.git master; then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This script is also updating csi-release-tools. Do we want to include that in the script or have separate scripts? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What do you mean separate? Do you mean everything in go-get-kubernetes? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we have 2 different scripts? One for updating csi-release-tools, and another for updating kubernetes dependencies? |
||
# Sometimes "--squash" leads to merge conflicts. Because we know that "release-tools" | ||
# is an unmodified copy of csi-release-tools, we can automatically resolve that | ||
# by replacing it completely. | ||
if [ -e .git/MERGE_MSG ] && [ -e .git/FETCH_HEAD ] && grep -q "^# Conflict" .git/MERGE_MSG; then | ||
rm -rf release-tools | ||
mkdir release-tools | ||
git archive FETCH_HEAD | tar -C release-tools -xf - | ||
git add release-tools | ||
git commit --file=.git/MERGE_MSG | ||
else | ||
exit 1 | ||
fi | ||
fi | ||
RETRY=0 | ||
while ! ./release-tools/go-get-kubernetes.sh -p "$v" && RETRY < $MAX_RETRY | ||
do | ||
RETRY=$((RETRY+1)) | ||
go mod tidy && go mod vendor && go mod tidy | ||
done | ||
go mod tidy && go mod vendor && go mod tidy | ||
git add --all | ||
git commit -m "Update dependency go modules for k8s v$v" | ||
git remote set-url origin "https://github.com/$username/$repo.git" | ||
make test | ||
git push origin "module-update-$i" --force | ||
# Create PR | ||
prbody=$(cat <<EOF | ||
Ran kubernetes-csi/csi-release-tools go-get-kubernetes.sh -p ${v}. | ||
|
||
|
||
\`\`\`release-note | ||
sunnylovestiramisu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Update kubernetes dependencies to v${v} | ||
\`\`\` | ||
EOF | ||
) | ||
gh pr create --title="Update dependency go modules for k8s v$v" --body "$prbody" --head "$username:module-update-master" --base "master" --repo="kubernetes-csi/$repo" | ||
done | ||
) | ||
fi | ||
done <<EOF | ||
csi-driver-host-path master | ||
csi-driver-iscsi master | ||
csi-driver-nfs master | ||
csi-lib-utils master | ||
csi-proxy master | ||
csi-test master | ||
external-attacher master | ||
external-health-monitor master | ||
external-provisioner master | ||
external-resizer master | ||
external-snapshotter master | ||
livenessprobe master | ||
node-driver-registrar master | ||
EOF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone runs into it, are there steps to follow to resolve the conflicts and rerun the script?