Reuse testing api #193
Merged
Reuse testing api #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing against a driver that is installed elsewhere, for example inside a virtual machine, we have to use TCP. When that virtual machine dies without closing the TCP connection, for example because of a simulated power loss, then gRPC by default only notices the dead connection when the OS times out the TCP connection, which takes over 10 minutes (on Linux). The gRPC documentation makes it sound like the keepalive pings are only needed when there is no active method call, but in practice (with gRPC v1.19.1 on Linux) such calls hung for over 10 minutes. Activating the keepalive ping fixed that.
It would be nice to build upon the test set and connection handling that is already done by csi-sanity when including csi-sanity in a custom test suite. The only reason why that wasn't possible is that some of the functionality unnecessarily wasn't marked for exporting. For an example that depends on these changes, see intel/pmem-csi#237.
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
cncf-cla: yes
lpabon
approved these changes
Apr 16, 2019
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpabon, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
suneeth51
pushed a commit
to suneeth51/csi-test
that referenced
this pull request
Sep 11, 2019
Reuse testing api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This enables better testing over TCP (dead connection detection) and reuse of the csi-sanity infrastructure in custom test suites.
Special notes for your reviewer:
This extends the API of the package and thus is a minor update.
Does this PR introduce a user-facing change?: