Skip to content

Bump up the csi spec version mention from 0.4.0 to 1.2.0 #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2020
Merged

Bump up the csi spec version mention from 0.4.0 to 1.2.0 #264

merged 1 commit into from
May 2, 2020

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Apr 29, 2020

Signed-off-by: Humble Chirammal [email protected]

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 29, 2020
@k8s-ci-robot k8s-ci-robot requested review from jsafrane and msau42 April 29, 2020 18:02
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2020
@humblec
Copy link
Contributor Author

humblec commented Apr 29, 2020

/assign @msau42
/assign @pohly

msau42
msau42 reviewed Apr 29, 2020
View reviewed changes
README.md
@@ -31,7 +31,7 @@ CSI driver.

### Note

* Master is for CSI v0.4.0. Please see the branches for other CSI releases.
* Master is for CSI v1.2.0. Please see the branches for other CSI releases.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The golang note is also out of date.

What do you think about having a compatibility matrix similar to what the other sidecar repos have?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msau42 thought about the golang , but it mention about minimum supported version ( here 1.9+), so is it correct to mention that we need 1.12+ for master ?

Regarding the compatibility matrix that's a good idea 👍 . However I have to fetch the details somehow. Its also possible to have a followup PR for compatibility matrix.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the min version of golang is. Our CI uses go1.13. @pohly do you have any thoughts here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the oldest version of Go is that the code still builds with.

I suppose a correct statement would be "building has been tested with the Go version specified in release-tools/travis.yml"...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would be better, confirming the golang compatibility will be a tediuous task unless we have building infra with all the different versions of go. I have updated the PR to include above statement. PTAL @pohly @msau42

@msau42
Copy link
Collaborator

msau42 commented May 2, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 99b7db9 into kubernetes-csi:master May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly left review comments

@msau42 msau42 msau42 left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@pohly pohly

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@humblec @msau42 @k8s-ci-robot @pohly