Skip to content

Update Kubernetse-CSI Secret Documentation #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2019
Merged

Update Kubernetse-CSI Secret Documentation #190

merged 1 commit into from
Aug 12, 2019

Conversation

saad-ali
Copy link
Member

@saad-ali saad-ali commented Aug 8, 2019 •
edited
Loading

Closes #189

/assign @msau42

CC @jingxu97 @xing-yang

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from lpabon and msau42 August 8, 2019 01:43
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2019
msau42
msau42 reviewed Aug 8, 2019
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2019
@saad-ali
Copy link
Member Author

PTAL

msau42
msau42 reviewed Aug 10, 2019
View reviewed changes
@saad-ali
Copy link
Member Author

PTAL

xing-yang
xing-yang reviewed Aug 10, 2019
View reviewed changes
@saad-ali
Copy link
Member Author

PTAL

@saad-ali saad-ali force-pushed the fixSecrets branch 2 times, most recently from 478eddd to 19085e6 Compare August 10, 2019 00:56
msau42
msau42 reviewed Aug 10, 2019
View reviewed changes
book/src/secrets-and-credentials-storage-class.md Outdated
* `csi.storage.k8s.io/node-publish-secret-name`
* `csi.storage.k8s.io/node-publish-secret-namespace`

CSI `external-provisioner` v1.2.0+ add support for the following keys in `StorageClass.parameters`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adds support

@saad-ali
Copy link
Member Author

PTAL

@msau42
Copy link
Collaborator

msau42 commented Aug 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit aa1d949 into kubernetes-csi:master Aug 12, 2019
@saad-ali saad-ali mentioned this pull request Aug 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@msau42 msau42 msau42 left review comments

@lpabon lpabon Awaiting requested review from lpabon

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation on Snapshot secret support
4 participants
@saad-ali @k8s-ci-robot @msau42 @xing-yang