deploy: split out RBAC, fix leadership election permissions #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RBAC definitions were not updated when introducing leadership election, which depends on the permission to modify endpoints in the current namespace. Having the RBAC definition in a separate file makes them usable as-is elsewhere without manual editing, for example in kubernetes/e2e.
k8s-ci-robot
added
cncf-cla: yes
|
This rbac.yaml file is identical to the one in the E2E PR kubernetes/kubernetes#69868 |
|
The testing was done with the 0.4 release. If I haven't missed something, the provisioner still uses endpoints. The change to use configmaps as in the external-attacher will have to update the rbac.yaml together with the code. |
This was referenced Oct 21, 2018
|
/lgtm |
2 similar comments
|
/lgtm |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kbsonlong
pushed a commit
to kbsonlong/external-provisioner
that referenced
this pull request
Dec 29, 2023
Bump version of csi-translation-lib to master to include translation lib for Azure Disk/File, updates for AWS, GCE, OpenStack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RBAC definitions were not updated when introducing leadership
election, which depends on the permission to modify endpoints in the
current namespace.
Having the RBAC definition in a separate file makes them usable as-is
elsewhere without manual editing, for example in kubernetes/e2e.