-
Notifications
You must be signed in to change notification settings - Fork 356
Update grpc, csi spec and few dependencies to latest #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just to mention: |
@msau42 tested with go 1.13 and its passing.
|
@msau42 addressed the comment. PTAL. |
go.mod
Outdated
github.com/container-storage-interface/spec v1.1.0 | ||
github.com/golang/mock v1.2.0 | ||
github.com/container-storage-interface/spec v1.2.0 | ||
github.com/golang/mock v1.4.3 | ||
github.com/kubernetes-csi/csi-lib-utils v0.7.0 | ||
github.com/kubernetes-csi/csi-test v2.0.0+incompatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update csi-test and external-snapshotter to the latest released versions as well? I'm actually surprised snapshotter is still on 1.2.1? Didn't we need the new beta apis? cc @xing-yang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msau42 Updated csi test and also external snapshotter. As you noticed external-snpahotter was on 1.2.x :( .
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: humblec, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…go_modules/k8s.io/client-go-0.27.1 Bump k8s.io/client-go from 0.27.0 to 0.27.1
Signed-off-by: Humble Chirammal [email protected]