Skip to content

Update grpc, csi spec and few dependencies to latest #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2020

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Apr 28, 2020

Signed-off-by: Humble Chirammal [email protected]


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 28, 2020
@k8s-ci-robot k8s-ci-robot requested review from jsafrane and msau42 April 28, 2020 18:00
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 28, 2020
@humblec
Copy link
Contributor Author

humblec commented Apr 28, 2020

Just to mention: make works on top of the PR. The other kube dependency update will be a follow-up PR.

@humblec
Copy link
Contributor Author

humblec commented Apr 28, 2020

/assign @msau42
/assign @jsafrane

@humblec
Copy link
Contributor Author

humblec commented Jun 15, 2020

@msau42 tested with go 1.13 and its passing.

                WARNING

 This projects is tested with Go v1.13.
 Your current Go version is v1.14.
 This may or may not be close enough.

 In particular test-gofmt and test-vendor
 are known to be sensitive to the version of
 Go.
======================================================

mkdir -p bin
CGO_ENABLED=0 GOOS=linux go build  -a -ldflags '-X main.version=v1.6.0-11-ge1ba62f2c -extldflags "-static"' -o ./bin/csi-provisioner ./cmd/csi-provisioner
if [ "$ARCH" = "amd64" ]; then \
   CGO_ENABLED=0 GOOS=windows go build  -a -ldflags '-X main.version=v1.6.0-11-ge1ba62f2c -extldflags "-static"' -o ./bin/csi-provisioner.exe ./cmd/csi-provisioner ; \
   CGO_ENABLED=0 GOOS=linux GOARCH=ppc64le go build  -a -ldflags '-X main.version=v1.6.0-11-ge1ba62f2c -extldflags "-static"' -o ./bin/csi-provisioner-ppc64le ./cmd/csi-provisioner ; \
fi

@humblec
Copy link
Contributor Author

humblec commented Jun 15, 2020

@msau42 addressed the comment. PTAL.

go.mod Outdated
github.com/container-storage-interface/spec v1.1.0
github.com/golang/mock v1.2.0
github.com/container-storage-interface/spec v1.2.0
github.com/golang/mock v1.4.3
github.com/kubernetes-csi/csi-lib-utils v0.7.0
github.com/kubernetes-csi/csi-test v2.0.0+incompatible
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update csi-test and external-snapshotter to the latest released versions as well? I'm actually surprised snapshotter is still on 1.2.1? Didn't we need the new beta apis? cc @xing-yang

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msau42 Updated csi test and also external snapshotter. As you noticed external-snpahotter was on 1.2.x :( .

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2020
@msau42
Copy link
Collaborator

msau42 commented Jun 17, 2020

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 91a2a04 into kubernetes-csi:master Jun 17, 2020
kbsonlong pushed a commit to kbsonlong/external-provisioner that referenced this pull request Dec 29, 2023
…go_modules/k8s.io/client-go-0.27.1

Bump k8s.io/client-go from 0.27.0 to 0.27.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants