Skip to content

Use sig-storage-lib-external-provisioner v7.0.1 #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

wongma7
Copy link

@wongma7 wongma7 commented Jun 29, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it: the newer lib contains the fix for #576
kubernetes-sigs/sig-storage-lib-external-provisioner#104

from release note https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/releases/tag/v7.0.0:

  • Set provision-by anno to the storage class provisioner Set provision-by anno to the storage class provisioner kubernetes-sigs/sig-storage-lib-external-provisioner#104 *
    • Previous behavior: the pv.kubernetes.io/provisioned-by PV annotation was always set to the Controller's primary provisionerName
    • New behavior: if additionalProvisionerNames is passed to the Controller then the pv.kubernetes.io/provisioned-by PV annotation is set to the provisionerName or additionalProvisionerNames equal to the PV's StorageClass.
      • For example, if you have a Controller with provisionerName: ebs.csi.aws.com and additionalProvisionerNames: [kubernetes.io/aws-ebs] then PVs created for StorageClass with provisioner: ebs.csi.aws.com will have annotation pv.kubernetes.io/provisioned-by: ebs.csi.aws.com and PVs created for StorageClass with provisioner: kubernetes.io/aws-ebs will have annotation pv.kubernetes.io/provisioned-by: kubernetes.io/aws-ebs

In addition, the newer lib lets us remove the serverVersion check at startup.

Which issue(s) this PR fixes:
Fixes #645

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Newly provisioned CSI Migration enabled PV will have "provisioned-by" annotation set to in-tree provisioner name instead of the CSI provisioner

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 29, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @wongma7. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 29, 2021
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 29, 2021
@msau42
Copy link
Collaborator

msau42 commented Jun 29, 2021

/ok-to-test
/assign @Jiawei0227

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 29, 2021
@Jiawei0227
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2021
@msau42
Copy link
Collaborator

msau42 commented Jun 29, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jiawei0227, msau42, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 61317e2 into kubernetes-csi:master Jun 29, 2021
@msau42 msau42 mentioned this pull request Aug 11, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sig-storage-lib-external-provisioner to v7.0.0
4 participants