Skip to content

Add E2E tests for deleting API objects out of order (finalizers) #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xing-yang opened this issue Mar 9, 2020 · 13 comments
Closed

Add E2E tests for deleting API objects out of order (finalizers) #270

xing-yang opened this issue Mar 9, 2020 · 13 comments
Assignees
@RaunakShah
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@xing-yang
Copy link
Collaborator

xing-yang commented Mar 9, 2020 •
edited
Loading

Test the following finalizers

  • "snapshot.storage.kubernetes.io/volumesnapshotcontent-bound-protection"
  • "snapshot.storage.kubernetes.io/volumesnapshot-bound-protection"
  • "snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection"
  • "snapshot.storage.kubernetes.io/pvc-as-source-protection"
@xing-yang xing-yang added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 9, 2020
@ggriffiths
Copy link
Member

/assign ggriffiths

@yuxiangqian
Copy link
Contributor

@ggriffiths ping on this issue. Are you still working on this issue？ I saw kubernetes/kubernetes#89705 is now approved. thanks

@ggriffiths
Copy link
Member

@yuxiangqian I don't think I'll have the bandwidth to work on this until next month. I'll unassign myself for now

@ggriffiths ggriffiths removed their assignment Jun 19, 2020
@AndiLi99 AndiLi99 mentioned this issue Jun 22, 2020
Closed
@AndiLi99
Copy link
Contributor

/assign @AndiLi99

@yuxiangqian
Copy link
Contributor

@ggriffiths thanks. @AndiLi99 will take a look on this.

@xing-yang
Copy link
Collaborator Author

Hi @humblec,

Do you want to work on this in 1.20? We need this for bringing snapshot to GA in 1.20. Thanks.

@humblec
Copy link
Contributor

humblec commented Sep 14, 2020

Hi @humblec,

Do you want to work on this in 1.20? We need this for bringing snapshot to GA in 1.20. Thanks.

@xing-yang sure.. Let me take that ! thanks for the ping

@xing-yang
Copy link
Collaborator Author

/assign @humblec

@xing-yang xing-yang removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 16, 2020
@xing-yang
Copy link
Collaborator Author

@humblec As discussed, I'll un-assign this one from you now and look for a new owner for 1.20.

@xing-yang xing-yang added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 6, 2020
@xing-yang
Copy link
Collaborator Author

This may be better achieved by using the csi mock driver with the javascript hooks:

@xing-yang
Copy link
Collaborator Author

/assign @RaunakShah

@xing-yang xing-yang removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 7, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2021
@xing-yang
Copy link
Collaborator Author

This is done: kubernetes/kubernetes#95863

Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-snapshotter that referenced this issue Apr 30, 2025
@Aishwarya-Hebbar
Squashed 'release-tools/' changes from 90efb2ca5..0a435bf98
02b08ab 
0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e8 Bump golang to 1.24.0
f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version
6dcb96a51 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 0a435bf987dd41314377818fa26a7bed006c01cd
@Aishwarya-Hebbar Aishwarya-Hebbar mentioned this issue Apr 30, 2025
Merged
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-snapshotter that referenced this issue May 2, 2025
@Aishwarya-Hebbar
Squashed 'release-tools/' changes from 90efb2ca5..0a435bf98
fd44709 
0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e8 Bump golang to 1.24.0
f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version
6dcb96a51 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 0a435bf987dd41314377818fa26a7bed006c01cd
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-snapshotter that referenced this issue May 13, 2025
@Aishwarya-Hebbar
Squashed 'release-tools/' changes from 90efb2ca5..0a435bf98
d685fab 
0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e8 Bump golang to 1.24.0
f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version
6dcb96a51 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 0a435bf987dd41314377818fa26a7bed006c01cd
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-snapshotter that referenced this issue May 13, 2025
@Aishwarya-Hebbar
Squashed 'release-tools/' changes from 90efb2ca5..0a435bf98
6de71bf 
0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e8 Bump golang to 1.24.0
f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version
6dcb96a51 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 0a435bf987dd41314377818fa26a7bed006c01cd
@Aishwarya-Hebbar Aishwarya-Hebbar mentioned this issue May 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaunakShah RaunakShah

Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@xing-yang @ggriffiths @humblec @RaunakShah @yuxiangqian @AndiLi99 @k8s-ci-robot @fejta-bot